From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58117) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTuAp-0002zk-IA for qemu-devel@nongnu.org; Tue, 16 Sep 2014 10:56:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTuAh-00069A-VJ for qemu-devel@nongnu.org; Tue, 16 Sep 2014 10:56:07 -0400 Received: from mail.kernel.org ([198.145.19.201]:56341) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTuAh-00067Y-Q0 for qemu-devel@nongnu.org; Tue, 16 Sep 2014 10:55:59 -0400 Date: Tue, 16 Sep 2014 17:52:25 +0300 From: "Michael S. Tsirkin" Message-ID: <20140916145225.GA14769@redhat.com> References: <1410719879-25181-1-git-send-email-mst@redhat.com> <20140916144324.GA7804@redhat.com> <54184427.7070202@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <54184427.7070202@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 00/12] pci, pc, virtio, misc bugfixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Peter Maydell , QEMU Developers On Tue, Sep 16, 2014 at 04:07:35PM +0200, Paolo Bonzini wrote: > Il 16/09/2014 16:43, Michael S. Tsirkin ha scritto: > >> >=20 > >> > /root/qemu/tests/test-qdev-global-props.c: In function =E2=80=98te= st_static_prop=E2=80=99: > >> > /root/qemu/tests/test-qdev-global-props.c:80:5: error: implicit > >> > declaration of function =E2=80=98g_test_trap_subprocess=E2=80=99 > >> > [-Werror=3Dimplicit-function-declaration] > >> > /root/qemu/tests/test-qdev-global-props.c:80:5: error: nested exte= rn > >> > declaration of =E2=80=98g_test_trap_subprocess=E2=80=99 [-Werror=3D= nested-externs] > >> >=20 > >> > This function was only added in glib 2.38, and our > >> > minimum version is 2.12. > >> >=20 > >> > thanks > >> > -- PMM > > The following should help? > >=20 > > Signed-off-by: Michael S. Tsirkin >=20 > We can still run a smaller suite of tests if subprocesses are not > available. That's a better option, and doesn't require build system te= sts. >=20 > Paolo Not sure I understand. Patch?