From: Marcelo Tosatti <mtosatti@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH] kvmclock: clarify usage of cpu_clean_all_dirty
Date: Tue, 16 Sep 2014 12:14:37 -0300 [thread overview]
Message-ID: <20140916151437.GA27819@amt.cnet> (raw)
Explain the cpu_clean_all_dirty call.
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
---
hw/i386/kvm/clock.c | 4 ++++
1 file changed, 4 insertions(+)
Index: qemu/hw/i386/kvm/clock.c
===================================================================
--- qemu.orig/hw/i386/kvm/clock.c 2014-09-16 12:12:00.622537799 -0300
+++ qemu/hw/i386/kvm/clock.c 2014-09-16 12:12:44.696555868 -0300
@@ -127,6 +127,10 @@
}
cpu_synchronize_all_states();
+ /*
+ * Make sure that CPU state is synchronized from KVM
+ * once every VM state change callback has finished.
+ */
cpu_clean_all_dirty();
ret = kvm_vm_ioctl(kvm_state, KVM_GET_CLOCK, &data);
if (ret < 0) {
next reply other threads:[~2014-09-16 15:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 15:14 Marcelo Tosatti [this message]
2014-09-16 15:42 ` [Qemu-devel] [PATCH] kvmclock: clarify usage of cpu_clean_all_dirty Paolo Bonzini
2014-09-16 15:55 ` Marcelo Tosatti
2014-09-16 16:03 ` Paolo Bonzini
2014-09-16 16:07 ` Marcelo Tosatti
2014-09-16 16:22 ` Paolo Bonzini
2014-09-16 16:48 ` Marcelo Tosatti
2014-09-16 16:54 ` Marcelo Tosatti
2014-09-16 18:10 ` Marcelo Tosatti
2014-09-16 16:03 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140916151437.GA27819@amt.cnet \
--to=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).