From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38
Date: Tue, 16 Sep 2014 19:43:21 +0300 [thread overview]
Message-ID: <20140916164321.GB8628@redhat.com> (raw)
In-Reply-To: <CAFEAcA8pusT_BWe8zqJGET76V2dXvo7VQuu6M97sxPorpaXAog@mail.gmail.com>
On Tue, Sep 16, 2014 at 09:28:03AM -0700, Peter Maydell wrote:
> On 16 September 2014 09:23, Paolo Bonzini <pbonzini@redhat.com> wrote:
> > Il 16/09/2014 18:20, Peter Maydell ha scritto:
> >>> > - bumping the minimum required version from 2.12 to 2.16. I suggest
> >>> > bumping to the currently required version for Windows, which is 2.20
> >>> > (released March 2009).
> >> The commit message for a52d28afb suggests that this bump would be
> >> dropping support for RHEL5. That doesn't seem like a great idea
> >> to me, especially if it's only for the benefit of a test program.
> >
> > Though you would just drop support for "make check" on RHEL5. Even
> > "make -k check" would roughly work.
>
> Can't we just put in the makefile and configure magic to skip
> the test if the glib version is too old for it?
>
> -- PMM
That's exactly what my patch did.
See 20140916144324.GA7804@redhat.com
You prefer that then?
next prev parent reply other threads:[~2014-09-16 16:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 15:43 [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38 Paolo Bonzini
2014-09-16 16:18 ` Michael S. Tsirkin
2014-09-16 16:20 ` Peter Maydell
2014-09-16 16:23 ` Paolo Bonzini
2014-09-16 16:28 ` Peter Maydell
2014-09-16 16:33 ` Paolo Bonzini
2014-09-16 16:45 ` Peter Maydell
2014-09-16 16:57 ` Michael S. Tsirkin
2014-09-16 17:23 ` Peter Maydell
2014-09-16 17:54 ` Michael S. Tsirkin
2014-09-16 16:43 ` Michael S. Tsirkin [this message]
2014-09-16 16:42 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140916164321.GB8628@redhat.com \
--to=mst@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).