From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTxxA-0006p4-Jq for qemu-devel@nongnu.org; Tue, 16 Sep 2014 14:58:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTxx4-0007BD-Fl for qemu-devel@nongnu.org; Tue, 16 Sep 2014 14:58:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55885) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTxx4-0007Aw-7H for qemu-devel@nongnu.org; Tue, 16 Sep 2014 14:58:10 -0400 Date: Tue, 16 Sep 2014 22:01:19 +0300 From: "Michael S. Tsirkin" Message-ID: <20140916190119.GA2465@redhat.com> References: <87wq94xc7v.fsf@blackfin.pond.sub.org> <5417F698.2060001@redhat.com> <87sijsq60x.fsf@blackfin.pond.sub.org> <5418040F.3020106@redhat.com> <20140916103709.GA17910@redhat.com> <541814D7.8040300@redhat.com> <20140916162634.GA2195@redhat.com> <54186507.2070405@redhat.com> <20140916165618.GC8628@redhat.com> <541881EC.4090508@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <541881EC.4090508@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: weidong.huang@huawei.com, aliguori@amazon.com, qemu-devel@nongnu.org, agraf@suse.de, Markus Armbruster , arei.gonglei@huawei.com, stefanha@redhat.com, peter.huangpeng@huawei.com, lcapitulino@redhat.com On Tue, Sep 16, 2014 at 08:31:08PM +0200, Paolo Bonzini wrote: > Il 16/09/2014 18:56, Michael S. Tsirkin ha scritto: > > On Tue, Sep 16, 2014 at 06:27:51PM +0200, Paolo Bonzini wrote: > >> Il 16/09/2014 18:26, Michael S. Tsirkin ha scritto: > >>> Right so types should be explicit. > >>> If an arbitrary string isn't allowed, this should be documented. > >>> It's not great as is: what's the format for macaddr? AA:BB:CC:DD:EE:FF? > >>> aa:bb:cc:dd:ee:ff? aabbccddeeff? 0xaabbccddeeff? > >>> But just saying "string" is going in the wrong direction imho. > >> > >> That's the purpose of documentation (docs/qdev-device-use.txt), > > > > That's not user documentation, that's developer documentation, > > isn't it? > > It's user documentation. It's not distributed because we suck at > documentation. > > >> and even > >> then is better done with examples. I don't think doing it in -device > >> foo,help (which I'm not even sure is particularly helpful. > > > > -device foo,help isn't helpful at all because it does not > > tell people what does each option do. > > But it really should be fixed. > > Exactly. > > >> I'm sympathetic towards fixing the drive->str change, but I have no idea > >> how to do it. > > > > Change legacy_name to point to a detailed human-readable > > description of the type? > > E.g. "Ethernet 6-byte MAC Address, format: AA:BB:CC:DD:EE:FF"? > > If libvirt can cope with > > e1000.mac=str (Ethernet 6-byte MAC Address, format: AA:BB:CC:DD:EE:FF) > > that would work for me. Shouldn't "str" be "string" in HMP? Eblake - type is ignored right? Does this mean anything to the right of = is ignored? > > We really really should add description to all properties, too. > > This is a huge job. We have hundreds of properties. > > Paolo Right. If we don't start we won't get there though, will we?