From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32943) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUDLX-0006jt-IR for qemu-devel@nongnu.org; Wed, 17 Sep 2014 07:24:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUDLS-0006wU-Hb for qemu-devel@nongnu.org; Wed, 17 Sep 2014 07:24:27 -0400 Received: from dew.nodalink.com ([95.130.14.197]:56388) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUDLS-0006vH-CB for qemu-devel@nongnu.org; Wed, 17 Sep 2014 07:24:22 -0400 Date: Wed, 17 Sep 2014 11:24:22 +0000 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20140917112422.GA21222@nodalink.com> References: <1410891148-28849-1-git-send-email-armbru@redhat.com> <1410891148-28849-11-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1410891148-28849-11-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, benoit.canet@nodalink.com On Tue, Sep 16, 2014 at 08:12:15PM +0200, Markus Armbruster wrote: > - s->enabled = dinfo ? bdrv_is_inserted(dinfo->bdrv) : 0; > + s->enabled = bs && bdrv_is_inserted(bs); This is not so mechanical but seems correct anyway. Reviewed-by: Benoit Canet