From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36872) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUDem-0003AS-S6 for qemu-devel@nongnu.org; Wed, 17 Sep 2014 07:44:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUDeh-00049q-Pj for qemu-devel@nongnu.org; Wed, 17 Sep 2014 07:44:20 -0400 Received: from dew.nodalink.com ([95.130.14.197]:56406) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUDeg-00049M-Dm for qemu-devel@nongnu.org; Wed, 17 Sep 2014 07:44:15 -0400 Date: Wed, 17 Sep 2014 11:44:15 +0000 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20140917114415.GE21222@nodalink.com> References: <1410891148-28849-1-git-send-email-armbru@redhat.com> <1410891148-28849-17-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1410891148-28849-17-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 16/23] pc87312: Drop unused members of PC87312State List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, benoit.canet@nodalink.com On Tue, Sep 16, 2014 at 08:12:21PM +0200, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > include/hw/isa/pc87312.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/include/hw/isa/pc87312.h b/include/hw/isa/pc87312.h > index befc8bd..bf74470 100644 > --- a/include/hw/isa/pc87312.h > +++ b/include/hw/isa/pc87312.h > @@ -47,13 +47,10 @@ typedef struct PC87312State { > > struct { > ISADevice *dev; > - BlockDriverState *drive[2]; > - uint32_t base; > } fdc; > > struct { > ISADevice *dev; > - uint32_t base; > } ide; > > MemoryRegion io; > -- > 1.9.3 > Reviewed-by: Benoit Canet