From: Kevin Wolf <kwolf@redhat.com>
To: "Benoît Canet" <benoit.canet@irqsave.net>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block: Validate node-name
Date: Wed, 17 Sep 2014 14:28:20 +0200 [thread overview]
Message-ID: <20140917122820.GA4737@noname.redhat.com> (raw)
In-Reply-To: <20140917114917.GA22298@irqsave.net>
Am 17.09.2014 um 13:49 hat Benoît Canet geschrieben:
>
>
> > +int qemu_opts_id_wellformed(const char *id)
>
> This return 0 and 1 as a bool.
> Could we make the function return bool in the same series ?
I considered the change (as you probably saw, the new block.c function
returns a bool), but then thought it wasn't important enough.
In any case, that would be something for a separate patch. If you think
it's important, I can send one.
> I wonder what are the possible interferences between !strchr("-._", id[i])
> and Jeff's node name auto naming series.
We might need to update the code then, but it would actually be a good
reason why auto-naming wouldn't hurt if it uses characters that you
can't use manually.
Kevin
next prev parent reply other threads:[~2014-09-17 12:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 11:31 [Qemu-devel] [PATCH] block: Validate node-name Kevin Wolf
2014-09-17 11:49 ` Benoît Canet
2014-09-17 12:28 ` Kevin Wolf [this message]
2014-09-18 7:50 ` Markus Armbruster
2014-09-17 13:29 ` Benoît Canet
2014-09-19 10:08 ` Stefan Hajnoczi
2014-09-19 13:21 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140917122820.GA4737@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=benoit.canet@irqsave.net \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).