From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46707) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUELa-0001NR-P9 for qemu-devel@nongnu.org; Wed, 17 Sep 2014 08:28:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUELU-0007ut-Kh for qemu-devel@nongnu.org; Wed, 17 Sep 2014 08:28:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46790) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUELU-0007u8-E0 for qemu-devel@nongnu.org; Wed, 17 Sep 2014 08:28:28 -0400 Date: Wed, 17 Sep 2014 14:28:20 +0200 From: Kevin Wolf Message-ID: <20140917122820.GA4737@noname.redhat.com> References: <1410953466-26543-1-git-send-email-kwolf@redhat.com> <20140917114917.GA22298@irqsave.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20140917114917.GA22298@irqsave.net> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] block: Validate node-name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Beno=EEt?= Canet Cc: qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com Am 17.09.2014 um 13:49 hat Beno=EEt Canet geschrieben: >=20 >=20 > > +int qemu_opts_id_wellformed(const char *id) >=20 > This return 0 and 1 as a bool. > Could we make the function return bool in the same series ? I considered the change (as you probably saw, the new block.c function returns a bool), but then thought it wasn't important enough. In any case, that would be something for a separate patch. If you think it's important, I can send one. > I wonder what are the possible interferences between !strchr("-._", id[= i]) > and Jeff's node name auto naming series. We might need to update the code then, but it would actually be a good reason why auto-naming wouldn't hurt if it uses characters that you can't use manually. Kevin