* [Qemu-devel] [PATCH] hmp: fix memory leak at hmp_info_block_jobs()
@ 2014-09-16 13:36 arei.gonglei
2014-09-16 15:11 ` Markus Armbruster
2014-09-17 13:02 ` Stefan Hajnoczi
0 siblings, 2 replies; 4+ messages in thread
From: arei.gonglei @ 2014-09-16 13:36 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, weidong.huang, armbru, lcapitulino, Gonglei, stefanha
From: Gonglei <arei.gonglei@huawei.com>
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
---
hmp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hmp.c b/hmp.c
index 40a90da..31fb6a1 100644
--- a/hmp.c
+++ b/hmp.c
@@ -679,6 +679,8 @@ void hmp_info_block_jobs(Monitor *mon, const QDict *qdict)
}
list = list->next;
}
+
+ qapi_free_BlockJobInfoList(list);
}
void hmp_info_tpm(Monitor *mon, const QDict *qdict)
--
1.7.12.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] hmp: fix memory leak at hmp_info_block_jobs()
2014-09-16 13:36 [Qemu-devel] [PATCH] hmp: fix memory leak at hmp_info_block_jobs() arei.gonglei
@ 2014-09-16 15:11 ` Markus Armbruster
2014-09-17 1:04 ` Gonglei (Arei)
2014-09-17 13:02 ` Stefan Hajnoczi
1 sibling, 1 reply; 4+ messages in thread
From: Markus Armbruster @ 2014-09-16 15:11 UTC (permalink / raw)
To: arei.gonglei; +Cc: kwolf, weidong.huang, qemu-devel, stefanha, lcapitulino
<arei.gonglei@huawei.com> writes:
> From: Gonglei <arei.gonglei@huawei.com>
>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
> hmp.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hmp.c b/hmp.c
> index 40a90da..31fb6a1 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -679,6 +679,8 @@ void hmp_info_block_jobs(Monitor *mon, const QDict *qdict)
> }
> list = list->next;
> }
> +
> + qapi_free_BlockJobInfoList(list);
> }
>
> void hmp_info_tpm(Monitor *mon, const QDict *qdict)
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] hmp: fix memory leak at hmp_info_block_jobs()
2014-09-16 15:11 ` Markus Armbruster
@ 2014-09-17 1:04 ` Gonglei (Arei)
0 siblings, 0 replies; 4+ messages in thread
From: Gonglei (Arei) @ 2014-09-17 1:04 UTC (permalink / raw)
To: Markus Armbruster
Cc: kwolf@redhat.com, Huangweidong (C), qemu-devel@nongnu.org,
stefanha@redhat.com, lcapitulino@redhat.com
> From: Markus Armbruster [mailto:armbru@redhat.com]
> Sent: Tuesday, September 16, 2014 11:12 PM
> To: Gonglei (Arei)
> Cc: qemu-devel@nongnu.org; kwolf@redhat.com; Huangweidong (C);
> lcapitulino@redhat.com; stefanha@redhat.com
> Subject: Re: [Qemu-devel] [PATCH] hmp: fix memory leak at
> hmp_info_block_jobs()
>
> <arei.gonglei@huawei.com> writes:
>
> > From: Gonglei <arei.gonglei@huawei.com>
> >
> > Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> > ---
> > hmp.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/hmp.c b/hmp.c
> > index 40a90da..31fb6a1 100644
> > --- a/hmp.c
> > +++ b/hmp.c
> > @@ -679,6 +679,8 @@ void hmp_info_block_jobs(Monitor *mon, const
> QDict *qdict)
> > }
> > list = list->next;
> > }
> > +
> > + qapi_free_BlockJobInfoList(list);
> > }
> >
> > void hmp_info_tpm(Monitor *mon, const QDict *qdict)
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
Thanks for review. :)
Best regards,
-Gonglei
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] hmp: fix memory leak at hmp_info_block_jobs()
2014-09-16 13:36 [Qemu-devel] [PATCH] hmp: fix memory leak at hmp_info_block_jobs() arei.gonglei
2014-09-16 15:11 ` Markus Armbruster
@ 2014-09-17 13:02 ` Stefan Hajnoczi
1 sibling, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2014-09-17 13:02 UTC (permalink / raw)
To: arei.gonglei
Cc: kwolf, weidong.huang, armbru, qemu-devel, lcapitulino, stefanha
[-- Attachment #1: Type: text/plain, Size: 328 bytes --]
On Tue, Sep 16, 2014 at 09:36:55PM +0800, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
> hmp.c | 2 ++
> 1 file changed, 2 insertions(+)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-09-17 13:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-16 13:36 [Qemu-devel] [PATCH] hmp: fix memory leak at hmp_info_block_jobs() arei.gonglei
2014-09-16 15:11 ` Markus Armbruster
2014-09-17 1:04 ` Gonglei (Arei)
2014-09-17 13:02 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).