From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35614) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUeiE-00024U-62 for qemu-devel@nongnu.org; Thu, 18 Sep 2014 12:37:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUei5-0002W3-4B for qemu-devel@nongnu.org; Thu, 18 Sep 2014 12:37:42 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:58999) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUei4-0002Qu-SM for qemu-devel@nongnu.org; Thu, 18 Sep 2014 12:37:33 -0400 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 18 Sep 2014 10:37:26 -0600 Received: from b01cxnp22036.gho.pok.ibm.com (b01cxnp22036.gho.pok.ibm.com [9.57.198.26]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 507D638C803D for ; Thu, 18 Sep 2014 12:37:24 -0400 (EDT) Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s8IGbOOv61866102 for ; Thu, 18 Sep 2014 16:37:24 GMT Received: from d01av04.pok.ibm.com (localhost [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s8IGbNQe012008 for ; Thu, 18 Sep 2014 12:37:23 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <20140916145225.GA14769@redhat.com> References: <1410719879-25181-1-git-send-email-mst@redhat.com> <20140916144324.GA7804@redhat.com> <54184427.7070202@redhat.com> <20140916145225.GA14769@redhat.com> Message-ID: <20140918163721.16792.84947@loki> Date: Thu, 18 Sep 2014 11:37:21 -0500 Subject: Re: [Qemu-devel] [PULL 00/12] pci, pc, virtio, misc bugfixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Paolo Bonzini Cc: Peter Maydell , QEMU Developers Quoting Michael S. Tsirkin (2014-09-16 09:52:25) > On Tue, Sep 16, 2014 at 04:07:35PM +0200, Paolo Bonzini wrote: > > Il 16/09/2014 16:43, Michael S. Tsirkin ha scritto: > > >> > = > > >> > /root/qemu/tests/test-qdev-global-props.c: In function =E2=80=98te= st_static_prop=E2=80=99: > > >> > /root/qemu/tests/test-qdev-global-props.c:80:5: error: implicit > > >> > declaration of function =E2=80=98g_test_trap_subprocess=E2=80=99 > > >> > [-Werror=3Dimplicit-function-declaration] > > >> > /root/qemu/tests/test-qdev-global-props.c:80:5: error: nested exte= rn > > >> > declaration of =E2=80=98g_test_trap_subprocess=E2=80=99 [-Werror= =3Dnested-externs] > > >> > = > > >> > This function was only added in glib 2.38, and our > > >> > minimum version is 2.12. > > >> > = > > >> > thanks > > >> > -- PMM > > > The following should help? > > > = > > > Signed-off-by: Michael S. Tsirkin > > = > > We can still run a smaller suite of tests if subprocesses are not > > available. That's a better option, and doesn't require build system te= sts. > > = > > Paolo > = > Not sure I understand. Patch? Maybe wrapping the test cases that depend on subprocesses with: #if !GLIB_CHECK_VERSION(2, 38, 0) g_test_add(...) #endif ? If there's still some discussion to be had around the qdev stuff would you consider sending a v2 without them? I'd like to make sure these are in befo= re the slirp CVE fix goes upstream so we can cut the 2.1.2 release soon after.