From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50303)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XUfc4-0007rj-7r
	for qemu-devel@nongnu.org; Thu, 18 Sep 2014 13:35:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XUfby-00023c-3k
	for qemu-devel@nongnu.org; Thu, 18 Sep 2014 13:35:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:23783)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XUfbx-00022z-RX
	for qemu-devel@nongnu.org; Thu, 18 Sep 2014 13:35:18 -0400
Date: Thu, 18 Sep 2014 20:38:27 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140918173827.GA27433@redhat.com>
References: <1410719879-25181-1-git-send-email-mst@redhat.com>
	<1410719879-25181-4-git-send-email-mst@redhat.com>
	<20140918162947.16792.44892@loki> <541B1108.6090708@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <541B1108.6090708@redhat.com>
Subject: Re: [Qemu-devel] [PULL 03/12] test-qdev-global-props: Run tests on
	subprocess
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Eduardo Habkost <ehabkost@redhat.com>, Michael Roth <mdroth@linux.vnet.ibm.com>, Don Slutz <dslutz@verizon.com>, qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>

On Thu, Sep 18, 2014 at 07:06:16PM +0200, Paolo Bonzini wrote:
> Il 18/09/2014 18:29, Michael Roth ha scritto:
> > <snip>
> > 
> >> >  int main(int argc, char **argv)
> >> >  {
> >> >      g_test_init(&argc, &argv, NULL);
> >> > @@ -174,9 +200,20 @@ int main(int argc, char **argv)
> >> >      type_register_static(&static_prop_type);
> >> >      type_register_static(&dynamic_prop_type);
> >> > 
> >> > -    g_test_add_func("/qdev/properties/static/default", test_static_prop);
> >> > -    g_test_add_func("/qdev/properties/static/global", test_static_globalprop);
> >> > -    g_test_add_func("/qdev/properties/dynamic/global", test_dynamic_globalprop);
> >> > +    g_test_add_func("/qdev/properties/static/default/subprocess",
> >> > +                    test_static_prop_subprocess);
> >> > +    g_test_add_func("/qdev/properties/static/default",
> >> > +                    test_static_prop);
> > Since in the code above test_static_prop is actually the test that re-runs
> > /qdev/properties/static/default/subprocess under g_test_trap_subprocess, aren't
> > the tests (or test function implementations) backwards?
> > 
> 
> No, it's correct.  The parent test is the parent function, the child
> test is the subprocess function.  The child test is automagically
> skipped by GTest, I don't know how that works.
> 
> Paolo

Based on the "subprocess" string in the path.