From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33246) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUiBC-0006be-1Z for qemu-devel@nongnu.org; Thu, 18 Sep 2014 16:19:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUiB0-0003z1-C7 for qemu-devel@nongnu.org; Thu, 18 Sep 2014 16:19:49 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:41324) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUiB0-0003yM-6t for qemu-devel@nongnu.org; Thu, 18 Sep 2014 16:19:38 -0400 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 18 Sep 2014 16:19:31 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <541A0C40.2030900@redhat.com> References: <1410989576-9311-1-git-send-email-mdroth@linux.vnet.ibm.com> <1410989576-9311-4-git-send-email-mdroth@linux.vnet.ibm.com> <541A0C40.2030900@redhat.com> Message-ID: <20140918201929.19243.3680@loki> Date: Thu, 18 Sep 2014 15:19:29 -0500 Subject: Re: [Qemu-devel] [PATCH v2 3/4] tests: add QMP input visitor test for unions with no discriminator List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, lcapitulino@redhat.com, famz@redhat.com, qemu-stable@nongnu.org, armbru@redhat.com Quoting Eric Blake (2014-09-17 17:33:36) > On 09/17/2014 03:32 PM, Michael Roth wrote: > > This more of an exercise of the dealloc visitor, where it may > = > s/This more/This is more/ > = > > erroneously use an uninitialized discriminator field as indication > > that union fields corresponding to that discriminator field/type are > > present, which can lead to attempts to free random chunks of heap > > memory. > > = > > Cc: qemu-stable@nongnu.org > > Reviewed-by: Eric Blake > > Reviewed-by: Paolo Bonzini > > Signed-off-by: Michael Roth > > --- > > tests/qapi-schema/qapi-schema-test.json | 10 ++++++++++ > > tests/qapi-schema/qapi-schema-test.out | 3 +++ > > tests/test-qmp-input-strict.c | 17 +++++++++++++++++ > > 3 files changed, 30 insertions(+) > > = > = > R-b still stands. Thanks, will send a v3 in a moment just to keep things clean. > = > -- = > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org