From: Stefan Hajnoczi <stefanha@redhat.com>
To: Jeff Cody <jcody@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block: vhdx - fix reading beyond pointer during image creation
Date: Fri, 19 Sep 2014 10:45:20 +0100 [thread overview]
Message-ID: <20140919094520.GE27501@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1410894726-21836-1-git-send-email-jcody@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 519 bytes --]
On Tue, Sep 16, 2014 at 03:12:06PM -0400, Jeff Cody wrote:
> In vhdx_create_metadata(), we allocate 40 bytes to entry_buffer for
> the various metadata table entries. However, we write out 64kB from
> that buffer into the new file. Only write out the correct 40 bytes.
>
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
> block/vhdx.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-09-19 9:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 19:12 [Qemu-devel] [PATCH] block: vhdx - fix reading beyond pointer during image creation Jeff Cody
2014-09-17 6:33 ` Markus Armbruster
2014-09-17 19:54 ` Jeff Cody
2014-09-18 6:47 ` Markus Armbruster
2014-09-18 7:43 ` Markus Armbruster
2014-09-19 9:45 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140919094520.GE27501@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).