From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48849) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUv7e-0008D5-As for qemu-devel@nongnu.org; Fri, 19 Sep 2014 06:09:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUv7Y-0005mT-FF for qemu-devel@nongnu.org; Fri, 19 Sep 2014 06:09:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43801) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUv7Y-0005j6-7T for qemu-devel@nongnu.org; Fri, 19 Sep 2014 06:08:56 -0400 Date: Fri, 19 Sep 2014 11:08:46 +0100 From: Stefan Hajnoczi Message-ID: <20140919100846.GF27501@stefanha-thinkpad.redhat.com> References: <1410953466-26543-1-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="H4SyuGOnfnj3aJqJ" Content-Disposition: inline In-Reply-To: <1410953466-26543-1-git-send-email-kwolf@redhat.com> Subject: Re: [Qemu-devel] [PATCH] block: Validate node-name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: benoit.canet@irqsave.net, qemu-devel@nongnu.org, armbru@redhat.com --H4SyuGOnfnj3aJqJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 17, 2014 at 01:31:06PM +0200, Kevin Wolf wrote: > The device_name of a BlockDriverState is currently checked because it is > always used as a QemuOpts ID and qemu_opts_create() checks whether such > IDs are wellformed. >=20 > node-name is supposed to share the same namespace, but it isn't checked > currently. This patch adds explicit checks both for device_name and > node-name so that the same rules will still apply even if QemuOpts won't > be used any more at some point. >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 16 +++++++++++++--- > include/qemu/option.h | 1 + > util/qemu-option.c | 4 ++-- > 3 files changed, 16 insertions(+), 5 deletions(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --H4SyuGOnfnj3aJqJ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUHACuAAoJEJykq7OBq3PIDm4IAJ4ia+futNc98CPUImBYdjCa MHfR1pOdjQrS8WifRLKEjLQ46nXTDu+SQxyqhGTydiUD1I7eRKbgjJBqf9Sgndtl ih0mTcmNF9QUBOvryUeWZdAvH182n+Odv0JeZqNlQFVvhOxBPoTxADCt4qagqIe/ vWhEt3cGYXNM6MSZzsbcxKqW4HmHjzeQnjKbgfMcnMLjsEDTYsWvfSnJf9rq9fBq d7WzE25qojygAXE3cLkqacBekTJnUCSkahIzGM+eLuXYMQZl2zC+6+Ny+rwUkL8e izP2/lhhxmma44bdy9cl85+jwYs7+8Fh+mSikREmboIDIyGE3iySEKtJIotoSyI= =OV7h -----END PGP SIGNATURE----- --H4SyuGOnfnj3aJqJ--