From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUvDL-00018Q-Il for qemu-devel@nongnu.org; Fri, 19 Sep 2014 06:15:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUvDD-00078u-W9 for qemu-devel@nongnu.org; Fri, 19 Sep 2014 06:14:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20405) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUvDD-00078N-ON for qemu-devel@nongnu.org; Fri, 19 Sep 2014 06:14:47 -0400 Date: Fri, 19 Sep 2014 11:14:26 +0100 From: Stefan Hajnoczi Message-ID: <20140919101426.GH27501@stefanha-thinkpad.redhat.com> References: <1411039850-1385-1-git-send-email-cnanakos@grnet.gr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="J/zg8ciPNcraoWb6" Content-Disposition: inline In-Reply-To: <1411039850-1385-1-git-send-email-cnanakos@grnet.gr> Subject: Re: [Qemu-devel] [PATCH v5 0/1] async: aio_context_new(): Handle event_notifier_init failure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chrysostomos Nanakos Cc: kwolf@redhat.com, pingfank@linux.vnet.ibm.com, famz@redhat.com, benoit@irqsave.net, jan.kiszka@siemens.com, mjt@tls.msk.ru, qemu-devel@nongnu.org, kroosec@gmail.com, sw@weilnetz.de, pbonzini@redhat.com, afaerber@suse.de, aliguori@amazon.com --J/zg8ciPNcraoWb6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 18, 2014 at 02:30:48PM +0300, Chrysostomos Nanakos wrote: > v4->v5 > ------ > * Set thread_id before calling aio_context_new(). That way qmp_query_ioth= reads() > will display thread_id -1 for a failed IOThread object than an uninitia= lized > value. > * qemu_init_main_loop() will return -EMFILE if aio_context_new() fail. The > actual failure reason is placed in the propagated error message. > * Initialize 'Error *local_error' value to NULL. >=20 > v3->v4 > ------ > * Remove escaped single quotes from error messages. > * Rephrase commit log. >=20 > v2->v3 > ------ > * Remove errno usage and print the detailed message based on errno when > event_notifier_init() fails. > * Propagate error and return from iothread_complete() if aio_context_new(= ) fails. > * Return if !iothread->ctx from iothread_instance_finalize(), used by QOM > when object_unref(obj) is called after user_creatable_complete() fails. > * Remove cosmetic fixes accidentally introduced by editor and fix code st= yle > issues. >=20 > v1->v2 > ------ > * aio_context_new() returns NULL if the initialization of event notifier = fails. > * Add descriptive error messages if aio_context_new() and event_notifier_= init() > fail. > * Fix gpollfds leak. >=20 >=20 > Chrysostomos Nanakos (1): > async: aio_context_new(): Handle event_notifier_init failure >=20 > async.c | 16 +++++++++++----- > include/block/aio.h | 2 +- > include/qemu/main-loop.h | 2 +- > iothread.c | 11 ++++++++++- > main-loop.c | 9 +++++++-- > qemu-img.c | 8 +++++++- > qemu-io.c | 7 ++++++- > qemu-nbd.c | 6 +++++- > tests/test-aio.c | 10 +++++++++- > tests/test-thread-pool.c | 10 +++++++++- > tests/test-throttle.c | 10 +++++++++- > vl.c | 5 +++-- > 12 files changed, 78 insertions(+), 18 deletions(-) >=20 > --=20 > 1.7.10.4 >=20 Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --J/zg8ciPNcraoWb6 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUHAICAAoJEJykq7OBq3PIEJ0IAI6glvXw2lTIVyYVaTdXmsL1 chZ3bbaKZ6frJLe/3VcVKPRqo+h6ueJZmJvDuR6w+zA63kHEE/xKsolxu5eDWeUj wuiEORHjJ/90eJIUPdDpcI1AcgjJgNzY/otpSfkhIkTqCg/6tZ5JtZJbvCzLvmZJ M+ZTZ0P/b/X7nZ6vPFmb5hCRm35zeEe7D5i5Q3mwkA7nXV19cvPy7VRm87HUHeLP DrzxDRMH4KxVeVO5WYoE04H8XyhrImGjrJ6uKXrJZ2gDJMDNc9BjrJ6yPre7ge8k InxWTIououNixvhBTe4qbNUv6y/nPpKbMmLrT2bTCoo/o7xUNg+4viOrUlvrKAU= =oadS -----END PGP SIGNATURE----- --J/zg8ciPNcraoWb6--