From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40787) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XVyTn-0004H8-H4 for qemu-devel@nongnu.org; Mon, 22 Sep 2014 03:56:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XVyTh-0007mO-98 for qemu-devel@nongnu.org; Mon, 22 Sep 2014 03:56:15 -0400 Date: Mon, 22 Sep 2014 09:55:43 +0200 From: Kevin Wolf Message-ID: <20140922075543.GA4026@noname.redhat.com> References: <1411053464-12666-1-git-send-email-atuvenie@cloudbasesolutions.com> <1411053464-12666-2-git-send-email-atuvenie@cloudbasesolutions.com> <541D86DC.9060701@msgid.tls.msk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <541D86DC.9060701@msgid.tls.msk.ru> Subject: Re: [Qemu-devel] [PATCH 1/1] qemu-img: Cannot create fixed vhdx image List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: qemu-trivial@nongnu.org, Adelina Tuvenie , Adelina Tuvenie , qemu-devel , Stefan Hajnoczi Am 20.09.2014 um 15:53 hat Michael Tokarev geschrieben: > 18.09.2014 19:17, Adelina Tuvenie wrote: > > > > When trying to create a fixed vhd image qemu-img will return the > > following error: > > > > qemu-img: test.vhdx: Could not create image: Cannot allocate memory > > > > This happens because of a incorrect check in vhdx.c. Specifficaly, > > in vhdx_create_bat(), after allocating memory for the BAT entry, > > there is a check to determine if the allocation was unsuccsessful. > > The error comes from the fact that it checks if s->bat isn't NULL, > > which is true in case of succsessful allocation, and exits with > > error ENOMEM. > > Applying to -trivial, as it is an obvious trivial one-liner, hopefully > it's okay for kwolf@ and stefanha@. But please, > > - Cc qemu-devel and the subsystem maintainers (Cc'ed) > - do not send an "intro" email for single patches > - do not attach the patch, place it inline if possible > > (Since the original patch was in an attachment, I copy it here for > completness: > > diff --git a/block/vhdx.c b/block/vhdx.c > index 796b7bd..5bf292e 100644 > --- a/block/vhdx.c > +++ b/block/vhdx.c > @@ -1593,7 +1593,7 @@ static int vhdx_create_bat(BlockDriverState *bs, BDRVVHDXState *s, > bdrv_has_zero_init(bs) == 0) { > /* for a fixed file, the default BAT entry is not zero */ > s->bat = g_try_malloc0(length); > - if (length && s->bat != NULL) { > + if (length && s->bat == NULL) { > ret = -ENOMEM; > goto exit; > } > ) Whoops, this is what happens when you make mechanical changes manually. And I fooled two reviewers with this code. :-) Acked-by: Kevin Wolf