From: Stefan Hajnoczi <stefanha@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4] vmdk: Fix integer overflow in offset calculation
Date: Mon, 22 Sep 2014 10:56:53 +0100 [thread overview]
Message-ID: <20140922095653.GA12513@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1411370144-536-1-git-send-email-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 865 bytes --]
On Mon, Sep 22, 2014 at 03:15:44PM +0800, Fam Zheng wrote:
> This fixes the bug introduced by commit c6ac36e (vmdk: Optimize cluster
> allocation).
>
> $ ~/build/master/qemu-io /stor/vm/arch.vmdk -c 'write 2G 1k'
> write failed: Invalid argument
>
> Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Signed-off-by: Fam Zheng <famz@redhat.com>
>
> ---
> v4: Fix typo in file header: 1014 -> 2014.
> v3: A new case 105 instead of embedding in 005. (Max)
> ---
> block/vmdk.c | 2 +-
> tests/qemu-iotests/105 | 70 ++++++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/105.out | 21 ++++++++++++++
> 3 files changed, 92 insertions(+), 1 deletion(-)
> create mode 100755 tests/qemu-iotests/105
> create mode 100644 tests/qemu-iotests/105.out
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-09-22 9:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 7:15 [Qemu-devel] [PATCH v4] vmdk: Fix integer overflow in offset calculation Fam Zheng
2014-09-22 9:56 ` Stefan Hajnoczi [this message]
2014-09-22 12:32 ` Max Reitz
2014-09-23 1:54 ` Fam Zheng
2014-09-22 12:40 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140922095653.GA12513@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).