From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW0Mo-0002X6-IP for qemu-devel@nongnu.org; Mon, 22 Sep 2014 05:57:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XW0Mh-0004Yu-CZ for qemu-devel@nongnu.org; Mon, 22 Sep 2014 05:57:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25733) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW0Mh-0004P4-3U for qemu-devel@nongnu.org; Mon, 22 Sep 2014 05:57:03 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8M9utL1010340 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 22 Sep 2014 05:56:56 -0400 Date: Mon, 22 Sep 2014 10:56:53 +0100 From: Stefan Hajnoczi Message-ID: <20140922095653.GA12513@stefanha-thinkpad.redhat.com> References: <1411370144-536-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mP3DRpeJDSE+ciuQ" Content-Disposition: inline In-Reply-To: <1411370144-536-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4] vmdk: Fix integer overflow in offset calculation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , qemu-devel@nongnu.org, Max Reitz --mP3DRpeJDSE+ciuQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 22, 2014 at 03:15:44PM +0800, Fam Zheng wrote: > This fixes the bug introduced by commit c6ac36e (vmdk: Optimize cluster > allocation). >=20 > $ ~/build/master/qemu-io /stor/vm/arch.vmdk -c 'write 2G 1k' > write failed: Invalid argument >=20 > Reported-by: Mark Cave-Ayland > Signed-off-by: Fam Zheng >=20 > --- > v4: Fix typo in file header: 1014 -> 2014. > v3: A new case 105 instead of embedding in 005. (Max) > --- > block/vmdk.c | 2 +- > tests/qemu-iotests/105 | 70 ++++++++++++++++++++++++++++++++++++++++= ++++++ > tests/qemu-iotests/105.out | 21 ++++++++++++++ > 3 files changed, 92 insertions(+), 1 deletion(-) > create mode 100755 tests/qemu-iotests/105 > create mode 100644 tests/qemu-iotests/105.out Reviewed-by: Stefan Hajnoczi --mP3DRpeJDSE+ciuQ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUH/JlAAoJEJykq7OBq3PIKDIH/j7V1kSilnr/AoZRuFwCiYFZ kf5K1UpB/cClre1aRKS7yW9lgUgz5kCwD6M0io18uTmQRkOGsgOFuIW4jJYQNdNz d+LmBWBftFGQjikE8RkVDGSWbldPCRcYIxy21wiTfgIwgnx+OM+XVXHx6Ie26R4a SmRbSU3ASw5z1KGb6xYIkI/KQkRlPECDvgf8qpvC5y25FdolbbYP9xH4PfQzuJQc dpQ/OwyqX86N/cFMOTCx1kRUymW5E4GdGYonM7pKgYbQFgxO2HibypqOx1OZuCBX wi7RtlczaRiFYbyrgiif8MQbJjETO34MFQKD7sxlQ0atedXKDtDNyq8JPUdHCJU= =BD2H -----END PGP SIGNATURE----- --mP3DRpeJDSE+ciuQ--