From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] blkdebug: show an error for invalid event names
Date: Mon, 22 Sep 2014 11:28:23 +0100 [thread overview]
Message-ID: <20140922102823.GC12513@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <33183CC9F5247A488A2544077AF1902086DD8B63@SZXEMA503-MBS.china.huawei.com>
[-- Attachment #1: Type: text/plain, Size: 837 bytes --]
On Sat, Sep 20, 2014 at 09:32:35AM +0000, Gonglei (Arei) wrote:
> > @@ -315,10 +320,21 @@ static int read_config(BDRVBlkdebugState *s, const
> > char *filename,
> >
> > d.s = s;
> > d.action = ACTION_INJECT_ERROR;
> > - qemu_opts_foreach(&inject_error_opts, add_rule, &d, 0);
> > + d.errp = &local_err;
> > + qemu_opts_foreach(&inject_error_opts, add_rule, &d, 1);
> > + if (local_err) {
> > + error_propagate(errp, local_err);
> > + ret = -EINVAL;
> > + goto fail;
> > + }
> >
>
> If this check failed, it don't need to reset &set_state_opts.
Setting up the rules has failed and we need to free the QemuOpts which
were built up in this function.
If we don't free them then there is a memory leak.
Why is it correct to avoid resetting set_state_opts?
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-09-22 10:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-20 8:55 [Qemu-devel] [PATCH] blkdebug: show an error for invalid event names Stefan Hajnoczi
2014-09-20 9:32 ` Gonglei (Arei)
2014-09-22 10:28 ` Stefan Hajnoczi [this message]
2014-09-22 10:49 ` Gonglei (Arei)
2014-09-22 11:21 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140922102823.GC12513@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).