From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW21P-0004nl-Rp for qemu-devel@nongnu.org; Mon, 22 Sep 2014 07:43:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XW21L-0007ZU-V4 for qemu-devel@nongnu.org; Mon, 22 Sep 2014 07:43:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33832) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW21L-0007X6-Oa for qemu-devel@nongnu.org; Mon, 22 Sep 2014 07:43:07 -0400 Date: Mon, 22 Sep 2014 12:42:47 +0100 From: "Daniel P. Berrange" Message-ID: <20140922114247.GE31563@redhat.com> References: <1411310339-27733-1-git-send-email-alex@alex.org.uk> <1411310339-27733-3-git-send-email-alex@alex.org.uk> <20140922113655.GI14882@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20140922113655.GI14882@redhat.com> Subject: Re: [Qemu-devel] [libvirt] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Ryan Harper , "quintela@redhat.com" , Libvirt , Serge Hallyn , qemu-devel@nongnu.org, Alexander Graf , Alex Bligh , Amit Shah , Andreas =?utf-8?Q?F=C3=A4rber?= , "Serge E. Hallyn" On Mon, Sep 22, 2014 at 02:36:55PM +0300, Michael S. Tsirkin wrote: > On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote: > > Add a configure option --enable-pc-1-0-qemu-kvm and the > > corresponding --disable-pc-1-0-qemu-kvm, defaulting > > to disabled. > > > > Rename machine type pc-1.0 to pc-1.0-qemu-git. > > > > Make pc-1.0 machine type an alias of either pc-1.0-qemu-kvm > > or pc-1.0-qemu-git depending on the value of the config > > option. > > > > Signed-off-by: Alex Bligh > > I have to say, this one bothers me. > We end up not being able to predict what does pc-1.0 > reference. Yeah, this is not good. Any single machine type name should have fixed semantics - having two different semantics depending on build options means mgmt apps can no longer simply compare the machine type name to determine if it is a match with the same name on a different host. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|