From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58604) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW2eW-0004RC-OL for qemu-devel@nongnu.org; Mon, 22 Sep 2014 08:23:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XW2eQ-0002sj-FO for qemu-devel@nongnu.org; Mon, 22 Sep 2014 08:23:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44441) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW2eQ-0002rA-8U for qemu-devel@nongnu.org; Mon, 22 Sep 2014 08:23:30 -0400 Date: Mon, 22 Sep 2014 15:26:45 +0300 From: "Michael S. Tsirkin" Message-ID: <20140922122645.GM14882@redhat.com> References: <1411385195-13495-1-git-send-email-lersek@redhat.com> <1411385195-13495-3-git-send-email-lersek@redhat.com> <5420105C.2090701@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <5420105C.2090701@suse.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/2] machine_parse(): list supported machine types in their registration order List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: peter.maydell@linaro.org, Laszlo Ersek , qemu-devel@nongnu.org, marcel.a@redhat.com On Mon, Sep 22, 2014 at 02:04:44PM +0200, Andreas F=E4rber wrote: > Am 22.09.2014 um 13:26 schrieb Laszlo Ersek: > > Based on the registration order captured in the previous patch, we so= rt > > the ad-hoc list printed for > >=20 > > qemu-system-XXXX -M \? >=20 > Agree that the order is worth sanitizing. I would however argue that > registration order is not entirely stable either if you think of non-PC > cases where there's dozens of source files registering one machine each. > I would therefore propose alphabetical order as we do for QOM'ified CPU= s. Did you try? Indeed for x86 sort -r on the list looks kind of ok: q35 Standard PC (Q35 + ICH9, 2009) (alias of pc-q35-2.1) pc Standard PC (i440FX + PIIX, 1996) (alias of pc-i440f= x-2.1) pc-q35-2.1 Standard PC (Q35 + ICH9, 2009) pc-q35-2.0 Standard PC (Q35 + ICH9, 2009) pc-q35-1.7 Standard PC (Q35 + ICH9, 2009) pc-q35-1.6 Standard PC (Q35 + ICH9, 2009) pc-q35-1.5 Standard PC (Q35 + ICH9, 2009) pc-q35-1.4 Standard PC (Q35 + ICH9, 2009) pc-i440fx-2.1 Standard PC (i440FX + PIIX, 1996) (default) pc-i440fx-2.0 Standard PC (i440FX + PIIX, 1996) pc-i440fx-1.7 Standard PC (i440FX + PIIX, 1996) pc-i440fx-1.6 Standard PC (i440FX + PIIX, 1996) pc-i440fx-1.5 Standard PC (i440FX + PIIX, 1996) pc-i440fx-1.4 Standard PC (i440FX + PIIX, 1996) pc-1.3 Standard PC (i440FX + PIIX, 1996) pc-1.2 Standard PC (i440FX + PIIX, 1996) pc-1.1 Standard PC (i440FX + PIIX, 1996) pc-1.0 Standard PC (i440FX + PIIX, 1996) pc-0.15 Standard PC (i440FX + PIIX, 1996) pc-0.14 Standard PC (i440FX + PIIX, 1996) pc-0.13 Standard PC (i440FX + PIIX, 1996) pc-0.12 Standard PC (i440FX + PIIX, 1996) pc-0.11 Standard PC (i440FX + PIIX, 1996) pc-0.10 Standard PC (i440FX + PIIX, 1996) none empty machine isapc ISA-only PC But this is just luck. Not so on other targets. Laszlo mentions aarch: z2 Zipit Z2 (PXA27x) xilinx-zynq-a9 Xilinx Zynq Platform Baseboard for Cortex-A9 virt ARM Virtual Machine vexpress-a9 ARM Versatile Express for Cortex-A9 vexpress-a15 ARM Versatile Express for Cortex-A15 versatilepb ARM Versatile/PB (ARM926EJ-S) versatileab ARM Versatile/AB (ARM926EJ-S) verdex Gumstix Verdex (PXA270) tosa Tosa PDA (PXA255) terrier Terrier PDA (PXA270) sx1-v1 Siemens SX1 (OMAP310) V1 sx1 Siemens SX1 (OMAP310) V2 spitz Spitz PDA (PXA270) smdkc210 Samsung SMDKC210 board (Exynos4210) realview-pbx-a9 ARM RealView Platform Baseboard Explore for Cortex-A= 9 realview-pb-a8 ARM RealView Platform Baseboard for Cortex-A8 realview-eb-mpcore ARM RealView Emulation Baseboard (ARM11MPCore) realview-eb ARM RealView Emulation Baseboard (ARM926EJ-S) nuri Samsung NURI board (Exynos4210) none empty machine n810 Nokia N810 tablet aka. RX-44 (OMAP2420) n800 Nokia N800 tablet aka. RX-34 (OMAP2420) musicpal Marvell 88w8618 / MusicPal (ARM926EJ-S) midway Calxeda Midway (ECX-2000) mainstone Mainstone II (PXA27x) lm3s811evb Stellaris LM3S811EVB lm3s6965evb Stellaris LM3S6965EVB kzm ARM KZM Emulation Baseboard (ARM1136) integratorcp ARM Integrator/CP (ARM926EJ-S) highbank Calxeda Highbank (ECX-1000) cubieboard cubietech cubieboard connex Gumstix Connex (PXA255) collie Collie PDA (SA-1110) cheetah Palm Tungsten|E aka. Cheetah PDA (OMAP310) canon-a1100 Canon PowerShot A1100 IS borzoi Borzoi PDA (PXA270) akita Akita PDA (PXA270) I guess it's almost reasonable if we special-case the empty machine somehow, but we also need to sort numbers properly a15 should be before a9? --=20 MST