From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35641) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW2m2-0007d2-W2 for qemu-devel@nongnu.org; Mon, 22 Sep 2014 08:31:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XW2lw-0006Kr-ST for qemu-devel@nongnu.org; Mon, 22 Sep 2014 08:31:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW2lw-0006Jf-Ji for qemu-devel@nongnu.org; Mon, 22 Sep 2014 08:31:16 -0400 Date: Mon, 22 Sep 2014 15:34:19 +0300 From: "Michael S. Tsirkin" Message-ID: <20140922123419.GA7992@redhat.com> References: <1410792279-2488-1-git-send-email-arei.gonglei@huawei.com> <20140922083421.GA13006@redhat.com> <541FE889.3050209@redhat.com> <33183CC9F5247A488A2544077AF1902086DD90B3@SZXEMA503-MBS.china.huawei.com> <541FF3F9.5060705@redhat.com> <33183CC9F5247A488A2544077AF1902086DD915A@SZXEMA503-MBS.china.huawei.com> <542010CE.3010209@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <542010CE.3010209@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: "Huangweidong (C)" , "stefanha@redhat.com" , "qemu-devel@nongnu.org" , "agraf@suse.de" , "Gonglei (Arei)" , "aliguori@amazon.com" , "Huangpeng (Peter)" , "lcapitulino@redhat.com" On Mon, Sep 22, 2014 at 02:06:38PM +0200, Paolo Bonzini wrote: > Il 22/09/2014 13:22, Gonglei (Arei) ha scritto: > > > This doesn't change the fact that ObjectProperty is a generic struct, > > > and adding alias-specific fields there is wrong. > > > > OK, Maybe I should find other ways to attach this purpose and > > avoid layering violation. Thanks! > > Unfortunately I cannot think of any. > > We could add a description field to ObjectProperty, and replace > legacy_name with a description. The output then would be > > virtio-blk.drive=str (drive) > That's a bit hackish, but perhaps it would be good enough for mst and > Markus? > > Paolo I would just drop "str" and replace it with drive. I seems to convey zero information. Description should be something more informative, e.g. (ID of a drive to use as a backend) Help for -device could add "Must match ID of a -drive option". Help for device HMP command could add "Must match ID of a drive command." -- MST