From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45692)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XW3GY-0006tW-Sf
	for qemu-devel@nongnu.org; Mon, 22 Sep 2014 09:03:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XW3GS-0006xE-PK
	for qemu-devel@nongnu.org; Mon, 22 Sep 2014 09:02:54 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44273)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XW3GS-0006wk-DW
	for qemu-devel@nongnu.org; Mon, 22 Sep 2014 09:02:48 -0400
Date: Mon, 22 Sep 2014 15:38:13 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140922123813.GC7992@redhat.com>
References: <1411310339-27733-1-git-send-email-alex@alex.org.uk>
	<1411310339-27733-2-git-send-email-alex@alex.org.uk>
	<20140922115039.GJ14882@redhat.com>
	<54A1B0FE-AF54-4B4B-BB92-9269A30E5437@alex.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54A1B0FE-AF54-4B4B-BB92-9269A30E5437@alex.org.uk>
Subject: Re: [Qemu-devel] [PATCH v3 1/2] Add machine type pc-1.0-qemu-kvm
 for live migrate compatibility with qemu-kvm
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Bligh <alex@alex.org.uk>
Cc: Ryan Harper <ryan.harper@canonical.com>, Serge Hallyn <serge.hallyn@canonical.com>, "quintela@redhat.com" <quintela@redhat.com>, Libvirt <libvir-list@redhat.com>, Serge Hallyn <serge.hallyn@ubuntu.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>, Cole Robinson <crobinso@redhat.com>, Amit Shah <amit.shah@redhat.com>, Bruce Rogers <brogers@suse.com>, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>, "Serge E. Hallyn" <serge@hallyn.com>

On Mon, Sep 22, 2014 at 01:28:30PM +0100, Alex Bligh wrote:
> Michael,
> 
> (Reordering)
> 
> On 22 Sep 2014, at 12:50, Michael S. Tsirkin <mst@redhat.com> wrote:
> 
> > 
> >> @@ -257,6 +259,11 @@ static int pit_dispatch_post_load(void *opaque, int version_id)
> >>     return 0;
> >> }
> >> 
> >> +static bool has_irq_disabled(void *opaque, int version_id)
> >> +{
> >> +    return (version_id >= 3) || ((version_id == 2) && qemu_kvm_1_0_compat);
> >> +}
> >> +
> > Can you add a device property like we do for
> > other compat behaviours?
> > That's better than a global variable.
> > Same for other devices.
> 
> I can see 'opaque' points to PIIX4PMState or PITCommonState. Do you mean
> to put them in there? Could you point to an example to copy.

Look for PC_COMPAT_ macros, we have a ton of flags like this.


> -- 
> Alex Bligh
> 
> 
>