From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35623) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW5cY-0005ve-4R for qemu-devel@nongnu.org; Mon, 22 Sep 2014 11:33:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XW5cS-0007o4-1d for qemu-devel@nongnu.org; Mon, 22 Sep 2014 11:33:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64228) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW5cR-0007ma-RA for qemu-devel@nongnu.org; Mon, 22 Sep 2014 11:33:39 -0400 Date: Mon, 22 Sep 2014 18:36:46 +0300 From: "Michael S. Tsirkin" Message-ID: <20140922153646.GB11272@redhat.com> References: <1411310339-27733-1-git-send-email-alex@alex.org.uk> <1411310339-27733-3-git-send-email-alex@alex.org.uk> <20140922113655.GI14882@redhat.com> <20140922114247.GE31563@redhat.com> <878ulb7k54.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <878ulb7k54.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [libvirt] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Ryan Harper , "quintela@redhat.com" , Libvirt , Serge Hallyn , qemu-devel@nongnu.org, Alexander Graf , Alex Bligh , Amit Shah , Andreas =?iso-8859-1?Q?F=E4rber?= , "Serge E. Hallyn" On Mon, Sep 22, 2014 at 05:24:55PM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > On Mon, Sep 22, 2014 at 02:36:55PM +0300, Michael S. Tsirkin wrote: > >> On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote: > >> > Add a configure option --enable-pc-1-0-qemu-kvm and the > >> > corresponding --disable-pc-1-0-qemu-kvm, defaulting > >> > to disabled. > >> > > >> > Rename machine type pc-1.0 to pc-1.0-qemu-git. > >> > > >> > Make pc-1.0 machine type an alias of either pc-1.0-qemu-kvm > >> > or pc-1.0-qemu-git depending on the value of the config > >> > option. > >> > > >> > Signed-off-by: Alex Bligh > >> > >> I have to say, this one bothers me. > >> We end up not being able to predict what does pc-1.0 > >> reference. > > > > Yeah, this is not good. Any single machine type name should have > > fixed semantics - having two different semantics depending on build > > options means mgmt apps can no longer simply compare the machine > > type name to determine if it is a match with the same name on a > > different host. > > You're right. However, this particular horse left the barn a long time > ago: the pc-* machine types differ in qemu-kvm and upstream QEMU. > > Sure, when qemu-kvm was merged back into QEMU, its machine type variants > were dropped. But they live on in various downstreams that just like > QEMU had to pick between compatibility with upstream QEMU and qemu-kvm, > but unlike QEMU picked compatibility with qemu-kvm. > > So this patch does *not* break any management apps by letting them "no > longer simply compare the machine type name to determine if it is a > match with the same name on a different host". They never could for > these messed up machine types, at least not without knowing exactly what > kind of QEMU runs on the hosts in question. > > All this patch does is adding another facet to "exactly what kind of > QEMU". Right, but IMHO doing it at compile-time is wrong. If distros want compatiblity with both sometimes, what then? Build two binaries with different flags? Should be a runtime option that management sets after (somehow?) figuring out what's going on, on source. How does it do that? Not sure - but I'm sure destination distro has no way to figure it out. -- MST