From: Stefan Hajnoczi <stefanha@gmail.com>
To: "john.liuli" <john.liuli@huawei.com>
Cc: qemu-devel@nongnu.org, Andreas Faerber <afaerber@suse.de>,
mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qtest: fix qtest log fd should be initialized before qtest chardev
Date: Mon, 22 Sep 2014 17:21:16 +0100 [thread overview]
Message-ID: <20140922162116.GC17221@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1409737926-3468-1-git-send-email-john.liuli@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 681 bytes --]
On Wed, Sep 03, 2014 at 05:52:06PM +0800, john.liuli wrote:
> From: Li Liu <john.liuli@huawei.com>
>
> qtest_log_fp should be inited before qemu_chr_add_handlers.
> If not the log dumped from callback functions may be lost.
>
> easy to reproduce it by command:
> "QTEST_LOG=1 QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64
> gtester -k --verbose -m=quick tests/qdev-monitor-test"
>
> The log "[I xxxxxx] OPENED" should be printed out by
> qtest_event, but does not.
>
> Signed-off-by: Li Liu <john.liuli@huawei.com>
> ---
> qtest.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-09-22 16:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 9:52 [Qemu-devel] [PATCH] qtest: fix qtest log fd should be initialized before qtest chardev john.liuli
2014-09-22 16:21 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140922162116.GC17221@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=afaerber@suse.de \
--cc=john.liuli@huawei.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).