From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49105)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XW6Ml-0000YE-8w
	for qemu-devel@nongnu.org; Mon, 22 Sep 2014 12:21:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XW6Mf-00041l-RG
	for qemu-devel@nongnu.org; Mon, 22 Sep 2014 12:21:31 -0400
Received: from mail-wg0-x230.google.com ([2a00:1450:400c:c00::230]:49214)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XW6Mf-0003zy-K5
	for qemu-devel@nongnu.org; Mon, 22 Sep 2014 12:21:25 -0400
Received: by mail-wg0-f48.google.com with SMTP id z12so2962366wgg.31
	for <qemu-devel@nongnu.org>; Mon, 22 Sep 2014 09:21:19 -0700 (PDT)
Date: Mon, 22 Sep 2014 17:21:16 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140922162116.GC17221@stefanha-thinkpad.redhat.com>
References: <1409737926-3468-1-git-send-email-john.liuli@huawei.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="KDt/GgjP6HVcx58l"
Content-Disposition: inline
In-Reply-To: <1409737926-3468-1-git-send-email-john.liuli@huawei.com>
Subject: Re: [Qemu-devel] [PATCH] qtest: fix qtest log fd should be
 initialized before qtest chardev
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "john.liuli" <john.liuli@huawei.com>
Cc: qemu-devel@nongnu.org, Andreas Faerber <afaerber@suse.de>, mst@redhat.com


--KDt/GgjP6HVcx58l
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 03, 2014 at 05:52:06PM +0800, john.liuli wrote:
> From: Li Liu <john.liuli@huawei.com>
>=20
> qtest_log_fp should be inited before qemu_chr_add_handlers.
> If not the log dumped from callback functions may be lost.
>=20
> easy to reproduce it by command:
> "QTEST_LOG=3D1 QTEST_QEMU_BINARY=3Dx86_64-softmmu/qemu-system-x86_64
> gtester -k --verbose -m=3Dquick tests/qdev-monitor-test"
>=20
> The log "[I xxxxxx] OPENED" should be printed out by
> qtest_event, but does not.
>=20
> Signed-off-by: Li Liu <john.liuli@huawei.com>
> ---
>  qtest.c |    9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

--KDt/GgjP6HVcx58l
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUIEx8AAoJEJykq7OBq3PIzKYH/AjMFWAF1g/nY02RDADDmwPa
rFGdXYdsn1yHKEcuokEFJITNs91cs+OSUIeqhg9wgqTPiXDb11/XWYlAolzJWPMz
W8dhxkiQzMXPFHUcrqd/gHR/BWqA2k0evStCwHQYWH7w7VvjxY3BLAwGl1sGSrAI
1bfkxK/bFI7+AWZF733xUx7lo3hCEpArjjH84r8d/+WiG+jC/ekAZHTqZUBSKHii
If0IfzhkMUfu4tgRSNiNBPp7n3tqW7hT4vEy5GhJXBD7vEpknCkDeBop8mUG9Hzl
kmHB1A2uru7g0O7p2R+eoPQxIE9mvtSkwDnBeDgUzalDgq9Ra5HCODrA0ZizL4o=
=jOwe
-----END PGP SIGNATURE-----

--KDt/GgjP6HVcx58l--