From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50414) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWGym-0004rE-4x for qemu-devel@nongnu.org; Mon, 22 Sep 2014 23:41:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWGyf-0006o4-Vh for qemu-devel@nongnu.org; Mon, 22 Sep 2014 23:41:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:65222) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWGyf-0006nn-Nl for qemu-devel@nongnu.org; Mon, 22 Sep 2014 23:41:21 -0400 Date: Tue, 23 Sep 2014 06:44:23 +0300 From: "Michael S. Tsirkin" Message-ID: <20140923034423.GD11272@redhat.com> References: <1411310339-27733-1-git-send-email-alex@alex.org.uk> <1411310339-27733-3-git-send-email-alex@alex.org.uk> <20140922113655.GI14882@redhat.com> <9532E4EE-C926-4A57-A77C-66A9F4352B1A@alex.org.uk> <20140922121000.GL14882@redhat.com> <54204418.7080500@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <54204418.7080500@suse.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Ryan Harper , Serge Hallyn , "quintela@redhat.com" , Libvirt , Serge Hallyn , "qemu-devel@nongnu.org" , Alexander Graf , Alex Bligh , Cole Robinson , Amit Shah , Bruce Rogers , "Serge E. Hallyn" On Mon, Sep 22, 2014 at 05:45:28PM +0200, Andreas F=E4rber wrote: > Am 22.09.2014 um 15:05 schrieb Alex Bligh: > >>> Sadly that is not true. For instance on Ubuntu Precise > >>> it's invoked as qemu-system-x86_64 by at least one > >>> management application known to me. > >> > >> Well change it to call qemu-kvm then :) > >> Also what happens if you install qemu as well? > >> Does it conflict? > >=20 > > I'm not an Ubuntu maintainer but AFAIK qemu-kvm is deprecated. > > It may only be there to support upgrades. > >=20 > > We still need to support migration from qemu running on Precise > > to qemu running on Trusty. The trusty instance may not have > > qemu-kvm installed. If we were looking at argv[0], we'd > > really want to look at it on the /sending/ machine. > >=20 > > Forcing qemu to be involved as qemu-kvm solely on the basis > > some users might want to migrate a VM in from a previous > > version does not sound practical. > >=20 > >>> I'm not quite sure why you say "legacy management > >>> applications". > >> > >> Because any non legacy one can be patched. > >=20 > > Well this is where we diverge. I think the distro needs > > a way to change the default behaviour, i.e. so the existing > > command line will do something different. > >=20 > >>> This applies to /any/ management application. > >>> Unless we're going to burden every management application > >>> with this problem, we need to fix it. > >>> > >>> Just as a reminder, the ./configure value defaults to > >>> off, which means there is no change in current behaviour. > >> > >> Yes but this still perpetuates the mess. > >> > >> If you prefer using -M pc-1.0, add a new property > >> and teach management to set it. > >> > >> But no silent compile-time behind the scenes changes please. > >=20 > > OK, how about we keep the aliases, and make pc-1.0 > > default to the pc-1.0-qemu-git. We then add a command > > line option to make pc-1.0 mean pc-1.0-qemu-kvm, with > > that obviously defaulting to off. > >=20 > > Then distros can then put the option in > > /etc/qemu/target-x86_64.conf or whatever. >=20 > What about adding a bool property "qemu-kvm-compat" to the MachineClass= ? > Then a qemu-kvm shell script (like SUSE uses) can pass -global > machine.qemu-kvm-compat=3Don whereas qemu-system-x86_64 would run in th= e > default non-qemu-kvm mode (config on disk would affect both). It would > also allow running -machine pc-0.15,qemu-kvm-compat=3Don, ditching lots= of > new machine names and avoiding the name bikeshedding. >=20 > Regards, > Andreas Ack. Exactly. > --=20 > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn= berg