From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40318) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWN4A-00014u-CA for qemu-devel@nongnu.org; Tue, 23 Sep 2014 06:11:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWN44-0002yK-Tg for qemu-devel@nongnu.org; Tue, 23 Sep 2014 06:11:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40053) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWN44-0002xy-M3 for qemu-devel@nongnu.org; Tue, 23 Sep 2014 06:11:20 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8NABFH7013241 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 23 Sep 2014 06:11:15 -0400 Date: Tue, 23 Sep 2014 11:11:12 +0100 From: Stefan Hajnoczi Message-ID: <20140923101112.GK2713@stefanha-thinkpad.redhat.com> References: <1411394595-15300-1-git-send-email-stefanha@redhat.com> <87vbof64ms.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1ppIqr1kl39GnwQx" Content-Disposition: inline In-Reply-To: <87vbof64ms.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH 0/3] trace: drop orphan events from ./trace-events List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org --1ppIqr1kl39GnwQx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 22, 2014 at 05:45:15PM +0200, Markus Armbruster wrote: > Stefan Hajnoczi writes: >=20 > > Over time a few unused trace events have been left behind in ./trace-ev= ents. > > Either the code that called them was deleted or the event was never cal= led in > > the first place. > > > > This is a clear violation of the solider's motto "no man left behind". = It's > > time to bring these trace events home. > > > > On a more serious note, unused trace events cause confusion to users wh= o want > > to enable existing instrumentation. On the SystemTap backend we get er= rors > > when attempting to enable them because the static probes that these eve= nts are > > based on do not exist. >=20 > Reviewed-by: Markus Armbruster >=20 > While you're at it, could you also clean up the pointers to source files > that have bit-rotted? Sure, please post a separate patch with your Signed-off-by and I'll merge it. Stefan > $ scripts/cleanup-trace-events.pl trace-events | diff -u trace-events - > --- trace-events 2014-09-22 17:40:04.228700732 +0200 > +++ - 2014-09-22 17:41:03.107310697 +0200 > @@ -836,7 +836,7 @@ > pvscsi_tx_rings_ppn(const char* label, uint64_t ppn) "%s page: %"PRIx64"" > pvscsi_tx_rings_num_pages(const char* label, uint32_t num) "Number of %s= pages: %u" > =20 > -# xen-all.c > +# xen-hvm.c > xen_ram_alloc(unsigned long ram_addr, unsigned long size) "requested: %#= lx, size %#lx" > xen_client_set_memory(uint64_t start_addr, unsigned long size, bool log_= dirty) "%#"PRIx64" size %#lx, log_dirty %i" > =20 > @@ -845,7 +845,7 @@ > xen_remap_bucket(uint64_t index) "index %#"PRIx64 > xen_map_cache_return(void* ptr) "%p" > =20 > -# hw/xen/xen_platform.c > +# hw/i386/xen/xen_platform.c > xen_platform_log(char *s) "xen platform: %s" > =20 > # qemu-coroutine.c > @@ -1075,6 +1075,7 @@ > vmware_scratch_write(uint32_t index, uint32_t value) "index %d, value 0x= %x" > vmware_setmode(uint32_t w, uint32_t h, uint32_t bpp) "%dx%d @ %d bpp" > =20 > +# vmstate.c > # savevm.c > savevm_section_start(const char *id, unsigned int section_id) "%s, secti= on_id %u" > savevm_section_end(const char *id, unsigned int section_id) "%s, section= _id %u" > @@ -1241,7 +1242,7 @@ > virtio_ccw_interpret_ccw(int cssid, int ssid, int schid, int cmd_code) "= VIRTIO-CCW: %x.%x.%04x: interpret command %x" > virtio_ccw_new_device(int cssid, int ssid, int schid, int devno, const c= har *devno_mode) "VIRTIO-CCW: add subchannel %x.%x.%04x, devno %04x (%s)" > =20 > -# hw/intc/s390_flic.c > +# hw/intc/s390_flic_kvm.c > flic_create_device(int err) "flic: create device failed %d" > flic_no_device_api(int err) "flic: no Device Contral API support %d" > flic_reset_failed(int err) "flic: reset failed %d" > @@ -1254,6 +1255,7 @@ > migrate_pending(uint64_t size, uint64_t max) "pending size %" PRIu64 " m= ax %" PRIu64 > migrate_transferred(uint64_t tranferred, uint64_t time_spent, double ban= dwidth, uint64_t size) "transferred %" PRIu64 " time_spent %" PRIu64 " band= width %g max_size %" PRId64 > =20 > +# target-ppc/kvm.c > # kvm-all.c > kvm_ioctl(int type, void *arg) "type 0x%x, arg %p" > kvm_vm_ioctl(int type, void *arg) "type 0x%x, arg %p" > @@ -1282,10 +1284,12 @@ > object_dynamic_cast_assert(const char *type, const char *target, const c= har *file, int line, const char *func) "%s->%s (%s:%d:%s)" > object_class_dynamic_cast_assert(const char *type, const char *target, c= onst char *file, int line, const char *func) "%s->%s (%s:%d:%s)" > =20 > -# hw/xen/xen_pvdevice.c > +# hw/i386/xen/xen_pvdevice.c > xen_pv_mmio_read(uint64_t addr) "WARNING: read from Xen PV Device MMIO s= pace (address %"PRIx64")" > xen_pv_mmio_write(uint64_t addr) "WARNING: write to Xen PV Device MMIO s= pace (address %"PRIx64")" > =20 > +# hw/i386/pc.c > +# hw/acpi/memory_hotplug.c > # hw/pci/pci_host.c > pci_cfg_read(const char *dev, unsigned devid, unsigned fnid, unsigned of= fs, unsigned val) "%s %02u:%u @0x%x -> 0x%x" > pci_cfg_write(const char *dev, unsigned devid, unsigned fnid, unsigned o= ffs, unsigned val) "%s %02u:%u @0x%x <- 0x%x" --1ppIqr1kl39GnwQx Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUIUdAAAoJEJykq7OBq3PILgEH/jbXBAZYgOoU9Bqs8BdFrLRC vtf174OfTccbeIPeDNrkEhoibV6azmomhVirToJyMu1sajgrQDevRAAhx2K+oBr3 n/rmVmtQZTD7A+QMNIX6WKQMgnYmrf8t4bIoxBb9EaD+iIg0MBxrbTiZgeTj6mt1 Wigrcoo836ZxT+SK4/WMycROsxIOQUCkIbPHEYTro7gbZ+esMm2WnfNFLZGwTzC+ M4FPVudOdJpUOKJfXrDvVcS+p7nswZndKoYVB9Yfkx3zWhcaz088uWlIvZh4CGEg CwNNslmUyZFI/rOj1xaT2nDXeFzf9VlWARgMu7BnM5CxsZerx1bsgQbTpqsf8oQ= =WJg9 -----END PGP SIGNATURE----- --1ppIqr1kl39GnwQx--