From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56834) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWbMu-0002zp-A2 for qemu-devel@nongnu.org; Tue, 23 Sep 2014 21:27:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWbMt-0000wi-5x for qemu-devel@nongnu.org; Tue, 23 Sep 2014 21:27:44 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:38601) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWbMs-0000uA-S6 for qemu-devel@nongnu.org; Tue, 23 Sep 2014 21:27:43 -0400 Date: Wed, 24 Sep 2014 10:51:35 +1000 From: David Gibson Message-ID: <20140924005135.GC24332@voom.redhat.com> References: <1411418316-5169-1-git-send-email-lersek@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yVhtmJPUSI46BTXb" Content-Disposition: inline In-Reply-To: <1411418316-5169-1-git-send-email-lersek@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 0/2] list supported machine types in well-defined order List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: peter.maydell@linaro.org, mst@redhat.com, marcel.a@redhat.com, qemu-devel@nongnu.org, agraf@suse.de, pbonzini@redhat.com, afaerber@suse.de --yVhtmJPUSI46BTXb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 22, 2014 at 10:38:34PM +0200, Laszlo Ersek wrote: > The first patch introduces a generic comparator. This comparator should > cover all machine types at once that don't belong to machine type > "families". Hence, for example, the output it produces for >=20 > qemu-system-aarch64 -M \? >=20 > is meant to be final. (See examples in the patches.) >=20 > The second patch files piix and q35 machine types into their respective > families. >=20 > Paolo said we needed to care about "pseries, pc, q35", but I got no clue > about "pseries", so I didn't touch that. It shouldn't be hard for > someone who knows "pseries" to post a followup patch that covers it. > Until then, "pseries" machine types are listed in alphabetical order (no > families). Acked-by: David Gibson pseries is fairly simple; there are two pseries machine types, plain "pseries" and "pseries-2.1". These should both be in the same family. Implementation needs to be a little different than for PC, because the pseries machines are fully QOM-ized so there are no QEMUMachine structures any more. We'll need to set family from the *_class_init() functions instead. This is then complicated a little, because there's a pending patch in agraf's tree which re-organizes the pseries machine types a ltitle. After that there are still two pseries machine types, "pseries-2.1" and "pseries-2.2" (aliased to "pseries"). Again, both should be in the "pseries" family. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --yVhtmJPUSI46BTXb Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUIhWXAAoJEGw4ysog2bOS9XkP/3TFjk1fJdDtCjUMb2ajwbxh IiuUKZhxXdawdkXIZFCw+MCE+K6kVLwb5BNYT53FQ0RcglzIt2DAUqJUCtcSIy7i pX780/+iLJj8b4tkAkjysF3TmJAHQKpOtcAV0Sp4k1zlqUhtYgOrPM5y3Kke8Lbj gJN0cdtZzKzncBEc5UulCXQiYkb6Ti8hD64OfmLT1IXMAPNm0UpGzw4yzFhooY7o e3zfurXuCIOWnnqPux0XDPPtw39AvjtPzOVh26NA680UNdV1ucyVc0TNAY2fPGBx is5AmMcLVlP/uGpT+JZYlN6UYQs+Fs0ypE8D1fC43c1LVzEbW+YLdTe704msv1aY oAG/did3yvEg1R3TFVQK/mi8c7aBg6vmAClw6LNATAkQOUhQXfaH1BW44jCAuCSI 3FnVyiIaI92gK/Ayj1JPjTtOzuwflComw+EJ/GovyTVBCt1PcB8nqflIdkRuFHOp gphZofJy4rHsdYD0TPiwYWSUyNBGNDv+Rl1TQqaNbY/raWR9nig2CkOWAXROZZjV TEDUdxhE/XuUwgZ/eZJcTHZibosMsiMzZlLtrBsDPpsd6z0LDI8CABPCBKnBILYg uR7uv85rO2qjrNTUng0A+erS77XUgrBJNLkzG758LhHyP62879K2ph92g9Aa0bYh j6Z732I6+dNBhEqKnNBV =Fksf -----END PGP SIGNATURE----- --yVhtmJPUSI46BTXb--