From: Stefan Hajnoczi <stefanha@gmail.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Fam Zheng <famz@redhat.com>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] virtio: Fix wrong type cast from pointer to long
Date: Wed, 24 Sep 2014 10:53:07 +0100 [thread overview]
Message-ID: <20140924095307.GI21137@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1411536002-14088-1-git-send-email-sw@weilnetz.de>
[-- Attachment #1: Type: text/plain, Size: 699 bytes --]
On Wed, Sep 24, 2014 at 07:20:02AM +0200, Stefan Weil wrote:
> Compiler warning (w32, w64):
>
> include/hw/virtio/virtio_ring.h:142:26: warning:
> cast from pointer to integer of different size [-Wpointer-to-int-cast]
>
> When sizeof(long) < sizeof(void *), this is not only a warning but a
> real program error.
>
> Add also missing blanks in the same statement.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>
> Peter, could you please apply this bug fix directly without pull request?
>
> Thanks
> Stefan
>
> include/hw/virtio/virtio_ring.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-09-24 9:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 5:20 [Qemu-devel] [PATCH] virtio: Fix wrong type cast from pointer to long Stefan Weil
2014-09-24 7:24 ` Markus Armbruster
2014-09-24 8:46 ` Fam Zheng
2014-09-24 12:44 ` Peter Maydell
2014-09-25 1:12 ` Fam Zheng
2014-09-24 9:53 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140924095307.GI21137@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).