From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42785) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWmn7-0001Mq-Ah for qemu-devel@nongnu.org; Wed, 24 Sep 2014 09:39:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWmmw-0002lB-HL for qemu-devel@nongnu.org; Wed, 24 Sep 2014 09:39:33 -0400 Received: from mail-wg0-x230.google.com ([2a00:1450:400c:c00::230]:50111) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWmmw-0002k9-A8 for qemu-devel@nongnu.org; Wed, 24 Sep 2014 09:39:22 -0400 Received: by mail-wg0-f48.google.com with SMTP id x13so3013268wgg.19 for ; Wed, 24 Sep 2014 06:39:16 -0700 (PDT) Date: Wed, 24 Sep 2014 14:39:14 +0100 From: Stefan Hajnoczi Message-ID: <20140924133914.GC14194@stefanha-thinkpad.redhat.com> References: <1411468626-20450-1-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XMCwj5IQnwKtuyBG" Content-Disposition: inline In-Reply-To: <1411468626-20450-1-git-send-email-stefanha@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] trace: tighten up trace-events regex to fix bad parse List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Eric Auger , qemu-devel@nongnu.org, =?iso-8859-1?Q?Llu=EDs?= Vilanova --XMCwj5IQnwKtuyBG Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 23, 2014 at 11:37:06AM +0100, Stefan Hajnoczi wrote: > Use \w for properties and trace event names since they are both drawn > from [a-zA-Z0-9_] character sets. >=20 > The .* for matching properties was too aggressive and caused the > following failure with foo(int rc) "(this is a test)": >=20 > Traceback (most recent call last): > File "scripts/tracetool.py", line 139, in > main(sys.argv) > File "scripts/tracetool.py", line 134, in main > binary=3Dbinary, probe_prefix=3Dprobe_prefix) > File "scripts/tracetool/__init__.py", line 334, in generate > events =3D _read_events(fevents) > File "scripts/tracetool/__init__.py", line 262, in _read_events > res.append(Event.build(line)) > File "scripts/tracetool/__init__.py", line 225, in build > return Event(name, props, fmt, args, arg_fmts) > File "scripts/tracetool/__init__.py", line 185, in __init__ > % ", ".join(unknown_props)) > ValueError: Unknown properties: foo(int, rc) >=20 > Cc: Llu=EDs Vilanova > Reported-by: Eric Auger > Signed-off-by: Stefan Hajnoczi > --- > v2: > * Fix regex to allow multiple properties [Llu=EDs] >=20 > scripts/tracetool/__init__.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied to my tracing tree: https://github.com/stefanha/qemu/commits/tracing Stefan --XMCwj5IQnwKtuyBG Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUIsmCAAoJEJykq7OBq3PIdnAH/jnjNIAHBBodsqhBKbFRB8kC XZvijVIv8/vAYNXtIv9hRg++JyGVaykqjhhPqaBRW0lxdGphoxobmRneM/wRnMmQ OcUQGF4IGNjrgAPOXnvxSXYeQZBQlRAQk+e1qnY8E7dqADl8dky3k1j6zXZoEf6n 2EJt8mCrVdfwatwDiLhq4NthSK2OCP/Y8DJBZ6xzVRDB+qnKVKXAcdPUPuJlLsfq 0VUFz7BR5dImHEox8WgSXushGFgemYdC6/PS+D16wNqEX7gKcqQFtEtGU1M+K+5p pAQugCcp+d8tnFK5ledHl7RSx4PHx90MQl4KhFMOGRYRFgtR1UXR1Gz2R2810g8= =niRR -----END PGP SIGNATURE----- --XMCwj5IQnwKtuyBG--