qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: dmitry@daynix.com, mst@redhat.com, agraf@suse.de,
	qemu-devel@nongnu.org, cornelia.huck@de.ibm.com,
	kraxel@redhat.com, amit.shah@redhat.com, borntraeger@de.ibm.com,
	rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH 29/30] qdev: drop legacy hotplug fields/methods
Date: Wed, 24 Sep 2014 17:37:40 +0200	[thread overview]
Message-ID: <20140924173740.2f3e37ec@nial.usersys.redhat.com> (raw)
In-Reply-To: <5422B35E.2020006@redhat.com>

On Wed, 24 Sep 2014 14:04:46 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Il 24/09/2014 13:48, Igor Mammedov ha scritto:
> > @@ -239,10 +239,7 @@ void qdev_unplug(DeviceState *dev, Error **errp)
> >              hotplug_handler_unplug(dev->parent_bus->hotplug_handler, dev, errp);
> >          }
> >      } else {
> > -        assert(dc->unplug != NULL);
> > -        if (dc->unplug(dev) < 0) { /* legacy handler */
> > -            error_set(errp, QERR_UNDEFINED_ERROR);
> > -        }
> > +        assert(0);
> >      }
> 
> This is not particularly nice, but it makes sense at this part of the
> series, since an
> 
>     assert(dev->parent_bus && dev->parent_bus->hotplug_handler);
> 
> would be changed immediately in the next patch.  Also, it would change
> indentation and make the patch bigger.  Hence, please consider adding a
> 31st patch that changes
> 
>     hotplug_ctrl = qdev_get_hotplug_handler(dev);
>     if (hotplug_ctrl) {
>         ...
>     } else {
>         assert(0);
>     }
> 
> to
> 
>     hotplug_ctrl = qdev_get_hotplug_handler(dev);
>     assert(hotplug_ctrl);
sure, I'll add extra patch

>     ...
> 
> Still, this patch is okay.
> 
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> Paolo

  reply	other threads:[~2014-09-24 15:38 UTC|newest]

Thread overview: 98+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-24 11:47 [Qemu-devel] [PATCH 00/30] complete conversion to hotplug-handler API Igor Mammedov
2014-09-24 11:47 ` [Qemu-devel] [PATCH 01/30] test: virtio-scsi: check if hot-plug/unplug works Igor Mammedov
2014-09-24 12:32   ` Paolo Bonzini
2014-09-24 11:47 ` [Qemu-devel] [PATCH 02/30] test: virtio-serial: " Igor Mammedov
2014-09-24 12:33   ` Paolo Bonzini
2014-09-24 11:47 ` [Qemu-devel] [PATCH 03/30] test: virtio-rng: " Igor Mammedov
2014-09-24 12:35   ` Paolo Bonzini
2014-09-24 11:47 ` [Qemu-devel] [PATCH 04/30] test: virtio-net: " Igor Mammedov
2014-09-24 12:35   ` Paolo Bonzini
2014-09-24 11:47 ` [Qemu-devel] [PATCH 05/30] test: virtio-blk: " Igor Mammedov
2014-09-24 12:35   ` Paolo Bonzini
2014-09-24 11:47 ` [Qemu-devel] [PATCH 06/30] test: usb: add port test to uhci unit test Igor Mammedov
2014-09-24 12:30   ` Gerd Hoffmann
2014-09-24 14:06     ` Igor Mammedov
2014-09-24 11:47 ` [Qemu-devel] [PATCH 07/30] test: usb: generic usb device hotplug Igor Mammedov
2014-09-24 11:47 ` [Qemu-devel] [PATCH 08/30] test: usb: usb-storage hotplug test Igor Mammedov
2014-09-24 11:47 ` [Qemu-devel] [PATCH 09/30] access BusState.allow_hotplug using wraper qbus_is_hotpluggable() Igor Mammedov
2014-09-24 12:32   ` Paolo Bonzini
2014-09-25  2:00   ` Tang Chen
2014-09-25  8:05     ` Igor Mammedov
2014-09-24 11:47 ` [Qemu-devel] [PATCH 10/30] qdev: HotplugHandler: rename unplug callback to unplug_request Igor Mammedov
2014-09-24 12:16   ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 11/30] qdev: HotplugHandler: provide unplug callback Igor Mammedov
2014-09-24 12:17   ` Paolo Bonzini
2014-09-25  1:53   ` Tang Chen
2014-09-25  8:07     ` Igor Mammedov
2014-09-24 11:48 ` [Qemu-devel] [PATCH 12/30] qdev: add simple/generic unplug callback for HotplugHandler Igor Mammedov
2014-09-24 12:17   ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 13/30] qdev: hotplug: set handler only if HOTPLUG_HANDLER interface is supported Igor Mammedov
2014-09-24 12:19   ` Paolo Bonzini
2014-09-24 14:01     ` Igor Mammedov
2014-09-25  2:06   ` Tang Chen
2014-09-24 11:48 ` [Qemu-devel] [PATCH 14/30] target-i386: ICC bus: replace BusState.allow_hotplug with hotplug_handler Igor Mammedov
2014-09-24 12:22   ` Paolo Bonzini
2014-09-24 14:37     ` Igor Mammedov
2014-09-24 14:50       ` Paolo Bonzini
2014-09-24 15:30         ` Igor Mammedov
2014-09-24 15:34           ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 15/30] virtio-pci: " Igor Mammedov
2014-09-24 12:23   ` Paolo Bonzini
2014-09-24 14:51     ` Igor Mammedov
2014-09-24 14:53       ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 16/30] virtio-serial: convert to hotplug-handler API Igor Mammedov
2014-09-24 12:24   ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 17/30] virtio-mmio: drop useless bus->allow_hotplug = 0 Igor Mammedov
2014-09-24 12:24   ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 18/30] s390x: drop not used allow_hotplug in event-facility Igor Mammedov
2014-09-24 12:24   ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 19/30] s390x: convert s390-virtio to hotplug handler API Igor Mammedov
2014-09-24 11:48 ` [Qemu-devel] [PATCH 20/30] s390x: convert virtio-ccw " Igor Mammedov
2014-09-25 11:08   ` Cornelia Huck
2014-09-25 13:11     ` Igor Mammedov
2014-09-25 14:32       ` Cornelia Huck
2014-09-25 15:26         ` Igor Mammedov
2014-09-24 11:48 ` [Qemu-devel] [PATCH 21/30] scsi: make scsi_bus_new() assign hotplug controller Igor Mammedov
2014-09-24 12:11   ` Paolo Bonzini
2014-09-24 12:14   ` Paolo Bonzini
2014-09-24 15:00     ` Igor Mammedov
2014-09-24 11:48 ` [Qemu-devel] [PATCH 22/30] scsi: convert pvscsi HBA to hotplug hander API Igor Mammedov
2014-09-24 12:13   ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 23/30] scsi: convert virtio-scsi HBA to hotplug handler API Igor Mammedov
2014-09-24 12:15   ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 24/30] scsi: cleanup not used anymore SCSIBusInfo{hotplug, hot_unplug} fields Igor Mammedov
2014-09-24 12:12   ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 25/30] usb-bot: drop not needed "allow_hotplug = 0" Igor Mammedov
2014-09-24 12:27   ` Paolo Bonzini
2014-09-24 15:15     ` Igor Mammedov
2014-09-24 15:21       ` Paolo Bonzini
2014-09-25  8:01         ` Gerd Hoffmann
2014-09-25  8:12           ` Igor Mammedov
2014-09-25 14:10             ` Gerd Hoffmann
2014-09-25  7:59       ` Gerd Hoffmann
2014-09-24 11:48 ` [Qemu-devel] [PATCH 26/30] usb-storage: make its storage SCSI bus hotpluggable explicitly Igor Mammedov
2014-09-24 12:30   ` Paolo Bonzini
2014-09-24 12:56     ` Gerd Hoffmann
2014-09-24 12:50   ` Gerd Hoffmann
2014-09-24 15:22     ` Igor Mammedov
2014-09-25  7:52       ` Gerd Hoffmann
2014-09-24 11:48 ` [Qemu-devel] [PATCH 27/30] usb-storage: drop not needed "allow_hotplug = 0" Igor Mammedov
2014-09-24 12:31   ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 28/30] usb: convert to hotplug handler API Igor Mammedov
2014-09-24 13:00   ` Gerd Hoffmann
2014-09-24 13:04     ` Paolo Bonzini
2014-09-24 13:23       ` Gerd Hoffmann
2014-09-24 15:39         ` Igor Mammedov
2014-09-25  7:50           ` Gerd Hoffmann
2014-09-25 10:55             ` Igor Mammedov
2014-09-25 12:47               ` Paolo Bonzini
2014-09-25 13:22                 ` Igor Mammedov
2014-09-24 15:40     ` Igor Mammedov
2014-09-24 11:48 ` [Qemu-devel] [PATCH 29/30] qdev: drop legacy hotplug fields/methods Igor Mammedov
2014-09-24 12:04   ` Paolo Bonzini
2014-09-24 15:37     ` Igor Mammedov [this message]
2014-09-24 11:48 ` [Qemu-devel] [PATCH 30/30] qdev: HotplugHandler: add support for unplugging BUS-less devices Igor Mammedov
2014-09-24 12:00   ` Paolo Bonzini
2014-09-24 13:01 ` [Qemu-devel] [PATCH 00/30] complete conversion to hotplug-handler API Cornelia Huck
2014-09-24 14:20   ` Igor Mammedov
2014-09-24 15:01     ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140924173740.2f3e37ec@nial.usersys.redhat.com \
    --to=imammedo@redhat.com \
    --cc=agraf@suse.de \
    --cc=amit.shah@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=dmitry@daynix.com \
    --cc=kraxel@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).