From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52272)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1XWp0g-0005bv-6e
	for qemu-devel@nongnu.org; Wed, 24 Sep 2014 12:01:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1XWp0Z-0007vg-Ux
	for qemu-devel@nongnu.org; Wed, 24 Sep 2014 12:01:42 -0400
Received: from mx1.redhat.com ([209.132.183.28]:12228)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1XWp0Z-0007uh-KP
	for qemu-devel@nongnu.org; Wed, 24 Sep 2014 12:01:35 -0400
Date: Wed, 24 Sep 2014 17:39:58 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20140924173958.5a150ec5@nial.usersys.redhat.com>
In-Reply-To: <1411565021.30748.9.camel@nilsson.home.kraxel.org>
References: <1411559299-19042-1-git-send-email-imammedo@redhat.com>
	<1411559299-19042-29-git-send-email-imammedo@redhat.com>
	<1411563641.30748.7.camel@nilsson.home.kraxel.org>
	<5422C168.9030001@redhat.com>
	<1411565021.30748.9.camel@nilsson.home.kraxel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 28/30] usb: convert to hotplug handler API
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: dmitry@daynix.com, mst@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, cornelia.huck@de.ibm.com, amit.shah@redhat.com, Paolo Bonzini <pbonzini@redhat.com>, borntraeger@de.ibm.com, rth@twiddle.net

On Wed, 24 Sep 2014 15:23:41 +0200
Gerd Hoffmann <kraxel@redhat.com> wrote:

>   Hi,
> 
> > > Can't we do this in usb_bus_new instead of duplicating in every host
> > > adapter?
> > 
> > So you would make TYPE_USB_BUS the hotplug handler itself, instead of
> > the controller?
> 
> I was more thinking of just setting the callback in common code, but if
> we can attach the hotplug interface to the usb bus itself not the usb
> host adapters that would be even better.  And it'll probably kill some
> headache for the companion controller case.
How making bus a HotplugHandler itself will help with companion controller?

> 
> cheers,
>   Gerd
> 
>