From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57692)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1XX3Vp-0006WO-N7
	for qemu-devel@nongnu.org; Thu, 25 Sep 2014 03:30:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1XX3Vk-0002k7-VX
	for qemu-devel@nongnu.org; Thu, 25 Sep 2014 03:30:49 -0400
Received: from mx1.redhat.com ([209.132.183.28]:24347)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1XX3Vk-0002jf-95
	for qemu-devel@nongnu.org; Thu, 25 Sep 2014 03:30:44 -0400
Date: Thu, 25 Sep 2014 09:30:30 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20140925073030.GA4667@noname.redhat.com>
References: <1411622627-22110-1-git-send-email-tony@bakeyournoodle.com>
	<87d2akdxug.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <87d2akdxug.fsf@blackfin.pond.sub.org>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] block/raw-posix: use seek_hole ahead of
 fiemap
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, Tony Breeds <tony@bakeyournoodle.com>, Max Reitz <mreitz@redhat.com>, =?iso-8859-1?Q?P=E1draig?= Brady <pbrady@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Michael Steffens <michael_steffens@posteo.de>

Am 25.09.2014 um 08:21 hat Markus Armbruster geschrieben:
> Please copy Kevin & Stefan for block patches.  Doing that for you.  I
> also copy Max, who left his fingerprints on commit 4f11aa8.
>=20
> Tony Breeds <tony@bakeyournoodle.com> writes:
>=20
> > The command
> >   qemu-img convert -O raw inputimage.qcow2 outputimage.raw
> >
> > intermittently creates corrupted output images, when the input image =
is not yet fully synchronized to disk.  This patch preferese the use of s=
eek_hole checks to determine if the sector is present in the disk image.

Does this fix the problem or does it just make it less likely that it
becomes apparent?

If there is a data corruptor, we need to fix it, not just ensure that
only the less common environments are affected.

> > While we're there modify try_fiemap() to set FIEMAP_FLAG_SYNC.

That looks like a logically separate change, so it should probably be
a separate patch.

Is this fix for the corruptor? The commit message doesn't make it
clear. If so and fiemap is safe now, why would we still prefer
seek_hole?

> > Reported-By: Michael Steffens <michael_steffens@posteo.de>
> > CC: P=E1draig Brady <pbrady@redhat.com>
> > Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>

Kevin