From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60826) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XX3iM-0002u7-U2 for qemu-devel@nongnu.org; Thu, 25 Sep 2014 03:43:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XX3iG-0006AO-8q for qemu-devel@nongnu.org; Thu, 25 Sep 2014 03:43:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4643) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XX3iG-00066d-22 for qemu-devel@nongnu.org; Thu, 25 Sep 2014 03:43:40 -0400 Date: Thu, 25 Sep 2014 09:43:23 +0200 From: Kevin Wolf Message-ID: <20140925074323.GD4667@noname.redhat.com> References: <1411465255-18896-1-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1411465255-18896-1-git-send-email-stefanha@redhat.com> Subject: Re: [Qemu-devel] [PATCH] vpc: fix beX_to_cpu() and cpu_to_beX() confusion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Jeff Cody , pl@kamp.de, qemu-devel@nongnu.org, Xiaodong Gong Am 23.09.2014 um 11:40 hat Stefan Hajnoczi geschrieben: > The beX_to_cpu() and cpu_to_beX() functions perform the same operation - > they do a byteswap if the host CPU endianness is little-endian or a > nothing otherwise. > > The point of two names for the same operation is that it documents which > direction the data is being converted. This makes it clear whether the > data is suitable for CPU processing or in its external representation. > > This patch fixes incorrect beX_to_cpu()/cpu_to_beX() usage. > > Signed-off-by: Stefan Hajnoczi Thanks, applied to the block branch. Kevin