From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37211) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XX4AV-0001w1-AR for qemu-devel@nongnu.org; Thu, 25 Sep 2014 04:12:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XX4AM-00054c-8i for qemu-devel@nongnu.org; Thu, 25 Sep 2014 04:12:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40343) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XX4AM-00053e-19 for qemu-devel@nongnu.org; Thu, 25 Sep 2014 04:12:42 -0400 Date: Thu, 25 Sep 2014 10:12:27 +0200 From: Igor Mammedov Message-ID: <20140925101227.001d70f3@nial.usersys.redhat.com> In-Reply-To: <1411632113.7154.6.camel@nilsson.home.kraxel.org> References: <1411559299-19042-1-git-send-email-imammedo@redhat.com> <1411559299-19042-26-git-send-email-imammedo@redhat.com> <5422B89B.7070805@redhat.com> <20140924171504.7d1e27f9@nial.usersys.redhat.com> <5422E160.6010500@redhat.com> <1411632113.7154.6.camel@nilsson.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 25/30] usb-bot: drop not needed "allow_hotplug = 0" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: dmitry@daynix.com, mst@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, cornelia.huck@de.ibm.com, amit.shah@redhat.com, Paolo Bonzini , borntraeger@de.ibm.com, rth@twiddle.net On Thu, 25 Sep 2014 10:01:53 +0200 Gerd Hoffmann wrote: > On Mi, 2014-09-24 at 17:21 +0200, Paolo Bonzini wrote: > > Il 24/09/2014 17:15, Igor Mammedov ha scritto: > > > But there is room for improvement here, > > > it it's possible to error out even earlier if usb-bot would be marked > > > as not hotpluggable device and add to qdev_device_add() check if > > > device is hotpluggable even before it's created. > > > > That would work too. Gerd, what about usb-uas? > > Basically the same camp as usb-bot. UAS doesn't suffer the LUN > numeration issue which BOT has, but there likewise is no signaling about > scsi devices coming and going. Thet's why a excluded UAS from this series, Do I need to make it hotpluggable (like SCSI HBAs without hotplug signalling)? /i.e./ it would be possible to hotplug it but guest won't notice the new drive on UAS until reboot/ > > cheers, > Gerd > >