From: Stefan Hajnoczi <stefanha@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] qemu-iotests: Fail test if explicit test case number is unknown
Date: Thu, 25 Sep 2014 11:18:31 +0100 [thread overview]
Message-ID: <20140925101831.GB19882@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1411527957-14211-1-git-send-email-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 618 bytes --]
On Wed, Sep 24, 2014 at 11:05:57AM +0800, Fam Zheng wrote:
> When we expand a number range, we just print "$id - unknown test,
> ignored", this is convenient if we want to run a range of tests.
>
> When we designate a test case number explicitly, we shouldn't just
> ignore it if the case script doesn't exist.
>
> Print an error and fail the test.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
>
> ---
> v2: In subject explict -> explicit.
> ---
> tests/qemu-iotests/common | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-09-25 10:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 3:05 [Qemu-devel] [PATCH v2] qemu-iotests: Fail test if explicit test case number is unknown Fam Zheng
2014-09-25 10:18 ` Stefan Hajnoczi [this message]
2014-09-25 13:27 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140925101831.GB19882@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).