qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Stefan Weil <sw@weilnetz.de>, Michael Tokarev <mjt@tls.msk.ru>,
	qemu-devel@nongnu.org, Cole Robinson <crobinso@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] build: preserve debug symbols with --enable-debug-info
Date: Thu, 25 Sep 2014 11:49:54 +0100	[thread overview]
Message-ID: <20140925104954.GE19882@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1411632395-10516-1-git-send-email-olaf@aepfle.de>

[-- Attachment #1: Type: text/plain, Size: 940 bytes --]

On Thu, Sep 25, 2014 at 10:06:35AM +0200, Olaf Hering wrote:
> During code review for xen I noticed that --enable-debug-info would
> still strip the binaries because strip_opt= defaults to yes.
> If --enable-debug-info is passed to configure it has to be assumed
> that not only the compiled binaries have debugsymbols, also the
> installed binaries should keep the symbols. The requirement to pass
> also --disable-strip looks odd.

Perhaps package maintainers rely on installed binaries not having debug
symbols?

It's common to split the debug symbols into separate ELF files that are
shipped in a different package (qemu-debuginfo or similar).

If you make this change and packagers are unaware, they could
accidentally ship qemu packages that contain the full debug symbols in
the binaries.

That said, I don't really know...  The package maintainers can give you
a definitive answer whether or not this is a good thing to do.

Stefan

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]

  parent reply	other threads:[~2014-09-25 10:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-25  8:06 [Qemu-devel] [PATCH] build: preserve debug symbols with --enable-debug-info Olaf Hering
2014-09-25 10:36 ` Peter Maydell
2014-09-25 10:47   ` Olaf Hering
2014-09-25 10:51     ` Peter Maydell
2014-09-25 10:49 ` Stefan Hajnoczi [this message]
2014-09-25 10:55   ` Olaf Hering
2014-09-25 11:05   ` Michael Tokarev
2014-09-25 13:51   ` Paolo Bonzini
2014-10-02 15:39     ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140925104954.GE19882@stefanha-thinkpad.redhat.com \
    --to=stefanha@redhat.com \
    --cc=crobinso@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=olaf@aepfle.de \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).