From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39443) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XX6cm-0007fv-GC for qemu-devel@nongnu.org; Thu, 25 Sep 2014 06:50:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XX6cg-0004kU-CJ for qemu-devel@nongnu.org; Thu, 25 Sep 2014 06:50:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:65330) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XX6cg-0004Zi-4S for qemu-devel@nongnu.org; Thu, 25 Sep 2014 06:50:06 -0400 Date: Thu, 25 Sep 2014 11:49:54 +0100 From: Stefan Hajnoczi Message-ID: <20140925104954.GE19882@stefanha-thinkpad.redhat.com> References: <1411632395-10516-1-git-send-email-olaf@aepfle.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zaRBsRFn0XYhEU69" Content-Disposition: inline In-Reply-To: <1411632395-10516-1-git-send-email-olaf@aepfle.de> Subject: Re: [Qemu-devel] [PATCH] build: preserve debug symbols with --enable-debug-info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Olaf Hering Cc: Peter Maydell , Stefan Weil , Michael Tokarev , qemu-devel@nongnu.org, Cole Robinson , Paolo Bonzini --zaRBsRFn0XYhEU69 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 25, 2014 at 10:06:35AM +0200, Olaf Hering wrote: > During code review for xen I noticed that --enable-debug-info would > still strip the binaries because strip_opt= defaults to yes. > If --enable-debug-info is passed to configure it has to be assumed > that not only the compiled binaries have debugsymbols, also the > installed binaries should keep the symbols. The requirement to pass > also --disable-strip looks odd. Perhaps package maintainers rely on installed binaries not having debug symbols? It's common to split the debug symbols into separate ELF files that are shipped in a different package (qemu-debuginfo or similar). If you make this change and packagers are unaware, they could accidentally ship qemu packages that contain the full debug symbols in the binaries. That said, I don't really know... The package maintainers can give you a definitive answer whether or not this is a good thing to do. Stefan --zaRBsRFn0XYhEU69 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUI/NSAAoJEJykq7OBq3PIh1MIAKa/5gLhNOJF3u2fbJVOnneN BjFOLMRnlXO22fuvEu2Qy5V+94i67OkEorgvE5QDHt0BH9sQfvbWE0HY6TJalth7 nyLlAYz2yUS7UgPSTmDvdjRuoHZ6Fe/lRJcebp9V1gSUJ/j0/9tAM0hTM28+fahX qQQJagAQF6D/bMVMxcRs8veVCk2oE8gLodtNr3/mLvyvEYbrh69vSOs39F1XXsEd nEHqQDUy4qiTYIgHd3xPlHSUH5AoViaqCV5IF+Kckqc0zbS6qVRvx/AOITPhC2Ox WrLPgkZlWPn/8xPr/unLSVuME9MJbjgwaCA3XHIYflvu8cvWX9VxUHT5Z8INix4= =+mu9 -----END PGP SIGNATURE----- --zaRBsRFn0XYhEU69--