From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43349) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XX98Q-0007I3-Hn for qemu-devel@nongnu.org; Thu, 25 Sep 2014 09:31:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XX98K-0005Hb-Dp for qemu-devel@nongnu.org; Thu, 25 Sep 2014 09:31:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17132) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XX98K-0005HA-6h for qemu-devel@nongnu.org; Thu, 25 Sep 2014 09:30:56 -0400 Date: Thu, 25 Sep 2014 15:25:05 +0200 From: Kevin Wolf Message-ID: <20140925132505.GP4667@noname.redhat.com> References: <1411631642-4391-1-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1411631642-4391-1-git-send-email-kwolf@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] block: Validate node-name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: benoit.canet@irqsave.net, stefanha@redhat.com Am 25.09.2014 um 09:54 hat Kevin Wolf geschrieben: > The device_name of a BlockDriverState is currently checked because it is > always used as a QemuOpts ID and qemu_opts_create() checks whether such > IDs are wellformed. > > node-name is supposed to share the same namespace, but it isn't checked > currently. This patch adds explicit checks both for device_name and > node-name so that the same rules will still apply even if QemuOpts won't > be used any more at some point. > > qemu-img used to use names with spaces in them, which isn't allowed any > more. Replace them with underscores. > > Signed-off-by: Kevin Wolf Applied to the block branch. Kevin