qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: "Slutz, Donald Christopher" <dslutz@verizon.com>
Cc: "mst@redhat.com" <mst@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"armbru@redhat.com" <armbru@redhat.com>,
	"Richard W.M. Jones" <rjones@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	"aliguori@amazon.com" <aliguori@amazon.com>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [Qemu-devel] [PATCH] -machine vmport=off: Allow disabling of VMWare ioport emulation
Date: Thu, 25 Sep 2014 16:07:34 +0100	[thread overview]
Message-ID: <20140925150734.GJ2348@work-vm> (raw)
In-Reply-To: <A3CD31A5D207064088A18AC2AF7B5DC6BF868F14@MIA20725MBX891B.apps.tmrk.corp>

* Slutz, Donald Christopher (dslutz@verizon.com) wrote:
> What is happening with this patch?  I would like to use this code.

I need to rework it for the new machine types code; but it was pretty
low down my list of priorities; but I can try and get a minute for it
again.

Dave

> 
>    -Don Slutz
> 
> ________________________________________
> From: qemu-devel-bounces+don=cloudswitch.com@nongnu.org [qemu-devel-bounces+don=cloudswitch.com@nongnu.org] on behalf of Gerd Hoffmann [kraxel@redhat.com]
> Sent: Tuesday, May 20, 2014 6:10 AM
> To: Richard W.M. Jones
> Cc: mst@redhat.com; qemu-devel@nongnu.org; armbru@redhat.com; Dr. David Alan Gilbert; aliguori@amazon.com; Anthony PERARD
> Subject: Re: [Qemu-devel] [PATCH] -machine vmport=off: Allow disabling of VMWare ioport emulation
> 
>   Hi,
> 
> > It was disabled in this patch.  The commit message is saying that
> > vmport cannot work in Xen, but I'm not exactly clear why.
> >
> >   commit 1611977c3d8fdbdac6090cbd1f5555cee4aed6d9
> >   Author: Anthony PERARD <anthony.perard@citrix.com>
> >   Date:   Tue May 3 17:06:54 2011 +0100
> >
> >     pc, Disable vmport initialisation with Xen.
> >
> >     This is because there is not synchronisation of the vcpu register
> >     between Xen and QEMU, so vmport can't work properly.
> 
> Ah, ok.  The backdoor has side effects (writing the port does modify
> vcpu registers).  That is the bit which is problematic for xen.  Scratch
> the idea then.
> 
> Original patch is fine.
> 
> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
> 
> cheers,
>   Gerd
> 
> 
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

  reply	other threads:[~2014-09-25 15:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-19 17:00 [Qemu-devel] [PATCH] -machine vmport=off: Allow disabling of VMWare ioport emulation Dr. David Alan Gilbert (git)
2014-05-19 17:03 ` Richard W.M. Jones
2014-05-20  7:40 ` Gerd Hoffmann
2014-05-20  8:47   ` Dr. David Alan Gilbert
2014-05-20  9:18     ` Richard W.M. Jones
2014-05-20 10:10       ` Gerd Hoffmann
2014-09-25 13:40         ` Slutz, Donald Christopher
2014-09-25 15:07           ` Dr. David Alan Gilbert [this message]
2014-09-25 17:47             ` Slutz, Donald Christopher
2014-09-25 18:00               ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140925150734.GJ2348@work-vm \
    --to=dgilbert@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=anthony.perard@citrix.com \
    --cc=armbru@redhat.com \
    --cc=dslutz@verizon.com \
    --cc=kraxel@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rjones@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).