From: David Gibson <david@gibson.dropbear.id.au>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/8] vga: Start cutting out non-32bpp conversion support
Date: Fri, 26 Sep 2014 14:10:33 +1000 [thread overview]
Message-ID: <20140926041033.GH24332@voom.redhat.com> (raw)
In-Reply-To: <1411397096-31566-2-git-send-email-kraxel@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 855 bytes --]
On Mon, Sep 22, 2014 at 04:44:49PM +0200, Gerd Hoffmann wrote:
> From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
> Nowadays, we either share a surface with the host, or we create
> a 32bpp ARGB console surface.
>
> So we only need to draw/convert to 32bpp, enabling us to remove
> all but one instance of vga_template.h inclusion (to be further
> cleaned up), rgb_to_pixel_* etc...
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
With the caveat that I'm not particularly familiar with the vga code.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-09-26 4:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 14:44 [Qemu-devel] [PATCH 0/8] vga cleanup series Gerd Hoffmann
2014-09-22 14:44 ` [Qemu-devel] [PATCH 1/8] vga: Start cutting out non-32bpp conversion support Gerd Hoffmann
2014-09-26 4:10 ` David Gibson [this message]
2014-09-22 14:44 ` [Qemu-devel] [PATCH 2/8] vga: Remove remainder of old conversion cruft Gerd Hoffmann
2014-09-26 4:10 ` David Gibson
2014-09-22 14:44 ` [Qemu-devel] [PATCH 3/8] vga: Separate LE and BE conversion functions Gerd Hoffmann
2014-09-26 4:16 ` David Gibson
2014-09-26 6:25 ` Gerd Hoffmann
2014-09-22 14:44 ` [Qemu-devel] [PATCH 4/8] vga: Remove rgb_to_pixel indirection Gerd Hoffmann
2014-09-26 4:18 ` David Gibson
2014-09-22 14:44 ` [Qemu-devel] [PATCH 5/8] vga: Simplify vga_draw_blank() a bit Gerd Hoffmann
2014-09-26 4:20 ` David Gibson
2014-09-22 14:44 ` [Qemu-devel] [PATCH 6/8] cirrus: Remove non-32bpp cursor drawing Gerd Hoffmann
2014-09-26 4:21 ` David Gibson
2014-09-22 14:44 ` [Qemu-devel] [PATCH 7/8] vga: Remove some "should be done in BIOS" comments Gerd Hoffmann
2014-09-26 4:22 ` David Gibson
2014-09-22 14:44 ` [Qemu-devel] [PATCH 8/8] vga: Rename vga_template.h to vga-helpers.h Gerd Hoffmann
2014-09-26 4:22 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140926041033.GH24332@voom.redhat.com \
--to=david@gibson.dropbear.id.au \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).