From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXN43-0006dv-Tx for qemu-devel@nongnu.org; Fri, 26 Sep 2014 00:23:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXN3z-0000yu-28 for qemu-devel@nongnu.org; Fri, 26 Sep 2014 00:23:27 -0400 Received: from ozlabs.org ([103.22.144.67]:45385) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXN3y-0000xX-N3 for qemu-devel@nongnu.org; Fri, 26 Sep 2014 00:23:22 -0400 Date: Fri, 26 Sep 2014 14:10:33 +1000 From: David Gibson Message-ID: <20140926041033.GH24332@voom.redhat.com> References: <1411397096-31566-1-git-send-email-kraxel@redhat.com> <1411397096-31566-2-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mhjHhnbe5PrRcwjY" Content-Disposition: inline In-Reply-To: <1411397096-31566-2-git-send-email-kraxel@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/8] vga: Start cutting out non-32bpp conversion support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org --mhjHhnbe5PrRcwjY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 22, 2014 at 04:44:49PM +0200, Gerd Hoffmann wrote: > From: Benjamin Herrenschmidt >=20 > Nowadays, we either share a surface with the host, or we create > a 32bpp ARGB console surface. >=20 > So we only need to draw/convert to 32bpp, enabling us to remove > all but one instance of vga_template.h inclusion (to be further > cleaned up), rgb_to_pixel_* etc... >=20 > Signed-off-by: Benjamin Herrenschmidt > Signed-off-by: Gerd Hoffmann Reviewed-by: David Gibson With the caveat that I'm not particularly familiar with the vga code. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --mhjHhnbe5PrRcwjY Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUJOc4AAoJEGw4ysog2bOSgVAP+wTVJ9z9Z7PdQPGiOpQoAdg3 lDMCae77OMf1/mC/PY9ey3RWslI+hrR1ib7RLtwJAffljOEFG20RmmtuufSX3aIU PVy4wwOER83malwq535ld651Ue7POnXWwGxd+jivmLocG7/yF2Rq3zbJhvwXx+tU iQCXqfH78A3WdvpWk63OEmpzFCyAFHFosksyw7iSU8wmcUl/Swv+AIoBhy8RM2TS Z3BhLIYjEqQPKx20yNbxzYLlCuP5YTeshxFMRssvqgukrpW4/h+x6b3mqmE53DZD UN7ioG18+jEAKXNDvvUdZBPQileMy6oJSCNwg/0UtxBMWD3zHOg22l5TKg6vRGiN lfjlg4sEAlMu9708qriqtXyIruBMK3fDwdwzjLx0sP8ocXiVXmWP9Oq+dZ6O/t3A lc8qlxu4q++sq3gw1NGAGGOBNu0IQQ6Y6UkzT1My/HVgdNtIpc8+vixwPJB6Zb/1 RUT+gEo5bxBYJXLy7yHwdt0iM1pqLx4nYnuypvJXuza6PhLWDr2FNdvhO0GgK6qX KwYWTncqNEN+jTnhURUVFmYqz7NySd3wNnuyIFmRzfvOYWV46J0wIlH2eoXRlNEn IxL4brhNWSKfJg/6DNT0sks6ynucLLJ6YxkTbTIwlMVgtD3noL9WK8ehLSWdN1Ha A6+3AN9BplkMdbDQGvvR =65+y -----END PGP SIGNATURE----- --mhjHhnbe5PrRcwjY--