From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXN43-0006dw-Uh for qemu-devel@nongnu.org; Fri, 26 Sep 2014 00:23:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXN3z-0000z3-2n for qemu-devel@nongnu.org; Fri, 26 Sep 2014 00:23:27 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:50724) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXN3y-0000xZ-N4 for qemu-devel@nongnu.org; Fri, 26 Sep 2014 00:23:23 -0400 Date: Fri, 26 Sep 2014 14:16:48 +1000 From: David Gibson Message-ID: <20140926041648.GJ24332@voom.redhat.com> References: <1411397096-31566-1-git-send-email-kraxel@redhat.com> <1411397096-31566-4-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rwgQ89ZNnFUwFHTC" Content-Disposition: inline In-Reply-To: <1411397096-31566-4-git-send-email-kraxel@redhat.com> Subject: Re: [Qemu-devel] [PATCH 3/8] vga: Separate LE and BE conversion functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org --rwgQ89ZNnFUwFHTC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 22, 2014 at 04:44:51PM +0200, Gerd Hoffmann wrote: > From: Benjamin Herrenschmidt >=20 > Provide different functions for converting from an LE vs a BE > framebuffer. We cannot rely on the simple cases always being > shared surfaces since cirrus will need to always shadow for > cursor emulation, so we need the full set of functions to > be able to later handle runtime switching. [snip] > > @@ -1572,19 +1585,19 @@ static void vga_draw_graphic(VGACommonState *s,= int full_update) > bits =3D 8; > break; > case 15: > - v =3D VGA_DRAW_LINE15; > - bits =3D 16; > + v =3D big_endian_fb ? VGA_DRAW_LINE15_BE : VGA_DRAW_LINE15_L= E; > + bits =3D 15; > break; > case 16: > - v =3D VGA_DRAW_LINE16; > - bits =3D 16; > + v =3D big_endian_fb ? VGA_DRAW_LINE16_BE : VGA_DRAW_LINE16_L= E; > + bits =3D 15; Is the change from bits=3D16 to bits=3D15 correct in this case? --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --rwgQ89ZNnFUwFHTC Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUJOiwAAoJEGw4ysog2bOSZWAP/3jujcjK7mO6wV1o5zs6kMKn 9iB6MeXTCaS1dPj6E3q/uz974j4OsrWHyDr2XlMON56iuCQ3/59KdyjAOBKeVlmx DxVPu2yKENNvqYM2OEB03Wpk9KdPybEquneOvSumMN64LScq6tW/tfJ4SS6LHbww b03LRjLVzHe70a5pOfN5m56lAElZ1T6CZ9gOpwUJe8PZ9Yjo0mW70lfaY4iIkh4N QXZPzRk0A3T5sLzI9oONQoMHBumUx8JtW8IOCBjWN2cZCfqEx47QBmgmSi66HK1/ vwmJh9MpR6KZOdfkgnthF6ZxbqcW4hWlQ687bI1motDRGMk/MSmjPvU11cAYoDF4 mtOrZWwX/AEadyjMM7m7R0V8tw6N6ueBFnidl8dDcc3fs6STaeri0gBJxwYlCAFC KS4+qyBwZKYgYsnCi7YIJqO+M5698IywTNVYn2xg/M40Kq4t2vSkHLKK/T2jS+0x JOjuvH0C6HNRmuGH0S1OurXYL7NX4DfFtE69/NUg170DMU2oRjV6vXw54Zn/AuXn i/JEU2d944rytdFyFKf2eUQX4tn+IFRHfxHXoCwJWR8PzJLnWtRDhFlq83VzF5YU Th7Q5lMYT4VpoLcxQdg8Y4cl0c7kbLApEKiayKJdn3U85Qnz6Du62598338cMtN4 QLiWR29CybabeRfZF0kI =SU1E -----END PGP SIGNATURE----- --rwgQ89ZNnFUwFHTC--