From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46703) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXTCK-0003KK-CV for qemu-devel@nongnu.org; Fri, 26 Sep 2014 06:56:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXTCE-0004po-E8 for qemu-devel@nongnu.org; Fri, 26 Sep 2014 06:56:24 -0400 Received: from mail-wi0-x233.google.com ([2a00:1450:400c:c05::233]:49777) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXTCE-0004pM-7i for qemu-devel@nongnu.org; Fri, 26 Sep 2014 06:56:18 -0400 Received: by mail-wi0-f179.google.com with SMTP id d1so11269667wiv.6 for ; Fri, 26 Sep 2014 03:56:12 -0700 (PDT) Date: Fri, 26 Sep 2014 09:32:52 +0100 From: Stefan Hajnoczi Message-ID: <20140926083252.GA10809@stefanha-thinkpad> References: <1411467581-2982-1-git-send-email-aik@ozlabs.ru> <20140924094759.GG21137@stefanha-thinkpad.redhat.com> <54235F94.3090607@ozlabs.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="liOOAslEiF7prFVr" Content-Disposition: inline In-Reply-To: <54235F94.3090607@ozlabs.ru> Subject: Re: [Qemu-devel] [PATCH] ohci: Fix compile errors without --enable-trace-backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: qemu-devel@nongnu.org, Gerd Hoffmann --liOOAslEiF7prFVr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 25, 2014 at 10:19:32AM +1000, Alexey Kardashevskiy wrote: > On 09/24/2014 07:47 PM, Stefan Hajnoczi wrote: > > On Tue, Sep 23, 2014 at 08:19:41PM +1000, Alexey Kardashevskiy wrote: > >> This adds a stub for ohci_td_pkt() function (which traces packets) > >> when configured without --enable-trace-backend > >> > >> Signed-off-by: Alexey Kardashevskiy > >> --- > >> > >> It should probably be squashed to > >> [PATCH] ohci: Convert fprint/DPRINTF/print to traces > >> > >> Sorry about that... > >> > >> --- > >> hw/usb/hcd-ohci.c | 6 ++++++ > >> 1 file changed, 6 insertions(+) > >> > >> diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c > >> index 4a4dd02..7ea871d 100644 > >> --- a/hw/usb/hcd-ohci.c > >> +++ b/hw/usb/hcd-ohci.c > >> @@ -920,6 +920,7 @@ static int ohci_service_iso_td(OHCIState *ohci, st= ruct ohci_ed *ed, > >> return 1; > >> } > >> =20 > >> +#ifdef trace_event_get_state > >> static void ohci_td_pkt(const char *msg, const uint8_t *buf, size_t l= en) > >> { > >> bool print16 =3D !!trace_event_get_state(TRACE_USB_OHCI_TD_PKT_SH= ORT); > >=20 > > The preferred define for this is CONFIG_TRACE_NOP. > >=20 > > Checking for trace_event_get_state could break if trace/control.h > > changes in the future. >=20 > I am not familiar with "dtrace" - are traces configurable with it? With > --enable-trace-backend=3Ddtrace, trace_event_get_state is not defined. dtrace has its own tools for enabling/disabling trace events. QEMU's command cannot be used with dtrace. --liOOAslEiF7prFVr Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUJSS0AAoJEJykq7OBq3PIeLIIAKlYFm8pkIigR52ecyr3n7al 7Ti4GLXiM36VzWQ2OUDfYBARLM8wnySCv9q6FXeWrPuMrMFwFfKT0xQldV6brCdO YUMcv1W0SYV5WGcAgQ9PQ+FyavdIYXTcwewGyd8p/aNGHtkkBvCnmj58/Lg3Ncn7 2rTXt6ROb7hsnZy5FzibPEDFJhiWDqR+X8RUbvp9DYgBLKb8ISQ+GulSDnB6xZzB ha/a6s/yAuyBUaz2dpcXmh9MsCT3TlsglBiHA1qDVeT5dbXncefLoEx9JvlIAC/o 8fABRud31ZfqiufrpoY0INSfLWifaSAMhbRuMVQV2jo9OsdkGF8YshJj5eMpqNI= =Koh5 -----END PGP SIGNATURE----- --liOOAslEiF7prFVr--