From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52811) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXTYJ-0007Ik-UX for qemu-devel@nongnu.org; Fri, 26 Sep 2014 07:19:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXTY9-0002hG-DM for qemu-devel@nongnu.org; Fri, 26 Sep 2014 07:19:07 -0400 Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:47637) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXTY9-0002fU-3S for qemu-devel@nongnu.org; Fri, 26 Sep 2014 07:18:57 -0400 Received: from /spool/local by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 26 Sep 2014 12:18:50 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 0674117D8045 for ; Fri, 26 Sep 2014 12:20:56 +0100 (BST) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s8QBIlBZ47120390 for ; Fri, 26 Sep 2014 11:18:48 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s8QBIkWq022478 for ; Fri, 26 Sep 2014 05:18:47 -0600 Date: Fri, 26 Sep 2014 13:18:45 +0200 From: Cornelia Huck Message-ID: <20140926131845.44b78a21.cornelia.huck@de.ibm.com> In-Reply-To: <1411723721-20484-26-git-send-email-imammedo@redhat.com> References: <1411723721-20484-1-git-send-email-imammedo@redhat.com> <1411723721-20484-26-git-send-email-imammedo@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 25/36] s390x: convert virtio-ccw to hotplug handler API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: mst@redhat.com, amit.shah@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, borntraeger@de.ibm.com, kraxel@redhat.com, dmitry@daynix.com, pbonzini@redhat.com, rth@twiddle.net On Fri, 26 Sep 2014 09:28:30 +0000 Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > v2: > fix not working unplug > --- > hw/s390x/virtio-ccw.c | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c > index 33a1d86..09d9500 100644 > --- a/hw/s390x/virtio-ccw.c > +++ b/hw/s390x/virtio-ccw.c > @@ -1624,9 +1624,7 @@ static void virtio_ccw_device_class_init(ObjectClass *klass, void *data) > dc->props = virtio_ccw_properties; > dc->init = virtio_ccw_busdev_init; > dc->exit = virtio_ccw_busdev_exit; > - dc->unplug = virtio_ccw_busdev_unplug; > dc->bus_type = TYPE_VIRTUAL_CSS_BUS; > - unrelated whitespace change (but I don't really mind) > } > > static const TypeInfo virtio_ccw_device_info = { Reviewed-by: Cornelia Huck