From: Igor Mammedov <imammedo@redhat.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: mst@redhat.com, amit.shah@redhat.com, agraf@suse.de,
qemu-devel@nongnu.org, borntraeger@de.ibm.com, kraxel@redhat.com,
dmitry@daynix.com, pbonzini@redhat.com, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v2 24/36] s390x: convert s390-virtio to hotplug handler API
Date: Fri, 26 Sep 2014 13:31:21 +0200 [thread overview]
Message-ID: <20140926133121.7c5c3580@nial.usersys.redhat.com> (raw)
In-Reply-To: <20140926131516.1535220d.cornelia.huck@de.ibm.com>
On Fri, 26 Sep 2014 13:15:16 +0200
Cornelia Huck <cornelia.huck@de.ibm.com> wrote:
> On Fri, 26 Sep 2014 09:28:29 +0000
> Igor Mammedov <imammedo@redhat.com> wrote:
>
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > ---
> > v2:
> > fix not working unplug
>
> While the current code for s390-virtio implements unplug, the transport
> per se does not really support unplug (and never has), only hotplugging
> of devices. I removed the ->unplug callback and qemu now behaves like
> I'd expect: I can add devices with device_add, but device_del leaves
> them in place. That would be the way to go for me.
Would a path to remove unplug on top of this one do or you'd prefer
me to respin this patch without unplug?
>
> > ---
> > hw/s390x/s390-virtio-bus.c | 12 +++++++-----
> > 1 file changed, 7 insertions(+), 5 deletions(-)
>
next prev parent reply other threads:[~2014-09-26 11:31 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 9:28 [Qemu-devel] [PATCH v2 00/36] complete conversion to hotplug-handler API Igor Mammedov
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 01/36] test: virtio-scsi: check if hot-plug/unplug works Igor Mammedov
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 02/36] test: virtio-serial: " Igor Mammedov
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 03/36] test: libqos: add qpci_plug_device_test() and qpci_unplug_acpi_device_test() Igor Mammedov
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 04/36] test: virtio-rng: check if hot-plug/unplug works Igor Mammedov
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 05/36] test: virtio-net: " Igor Mammedov
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 06/36] test: virtio-blk: " Igor Mammedov
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 07/36] test: usb: move uhci port test code to libqos/usb.c Igor Mammedov
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 08/36] test: usb: add port test to uhci unit test Igor Mammedov
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 09/36] test: usb: generic usb device hotplug Igor Mammedov
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 10/36] test: usb: usb-storage hotplug test Igor Mammedov
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 11/36] test: usb: usb-uas " Igor Mammedov
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 12/36] access BusState.allow_hotplug using wraper qbus_is_hotpluggable() Igor Mammedov
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 13/36] qdev: do not allow to instantiate non hotpluggable device with device_add Igor Mammedov
2014-09-29 10:58 ` Paolo Bonzini
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 14/36] qdev: HotplugHandler: rename unplug callback to unplug_request Igor Mammedov
2014-09-29 11:19 ` Michael S. Tsirkin
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 15/36] qdev: HotplugHandler: provide unplug callback Igor Mammedov
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 16/36] qdev: add simple/generic unplug callback for HotplugHandler Igor Mammedov
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 17/36] qdev: add wrapper to set BUS as HotplugHandler Igor Mammedov
2014-09-29 10:59 ` Paolo Bonzini
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 18/36] qdev: drop hotplug check from bus_add_child() Igor Mammedov
2014-09-29 11:01 ` Paolo Bonzini
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 19/36] target-i386: ICC bus: drop BusState.allow_hotplug Igor Mammedov
2014-09-29 11:00 ` Paolo Bonzini
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 20/36] virtio-pci: " Igor Mammedov
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 21/36] virtio-serial: convert to hotplug-handler API Igor Mammedov
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 22/36] virtio-mmio: drop useless bus->allow_hotplug = 0 Igor Mammedov
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 23/36] s390x: drop not used allow_hotplug in event-facility Igor Mammedov
2014-09-26 10:52 ` Cornelia Huck
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 24/36] s390x: convert s390-virtio to hotplug handler API Igor Mammedov
2014-09-26 11:15 ` Cornelia Huck
2014-09-26 11:31 ` Igor Mammedov [this message]
2014-09-26 11:36 ` Cornelia Huck
2014-09-26 12:08 ` [Qemu-devel] [PATCH v3 " Igor Mammedov
2014-09-26 12:15 ` Cornelia Huck
2014-09-26 12:29 ` Igor Mammedov
2014-09-26 12:37 ` [Qemu-devel] [PATCH v4 " Igor Mammedov
2014-09-26 13:06 ` Cornelia Huck
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 25/36] s390x: convert virtio-ccw " Igor Mammedov
2014-09-26 11:18 ` Cornelia Huck
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 26/36] scsi: set SCSI BUS itself as default HotplugHandler Igor Mammedov
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 27/36] scsi: convert pvscsi HBA to hotplug handler API Igor Mammedov
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 28/36] scsi: convert virtio-scsi " Igor Mammedov
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 29/36] scsi: cleanup not used anymore SCSIBusInfo{hotplug, hot_unplug} fields Igor Mammedov
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 30/36] usb-bot: mark device as non hotpluggable Igor Mammedov
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 31/36] usb-bot: drop not needed "allow_hotplug = 0" Igor Mammedov
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 32/36] usb-storage: " Igor Mammedov
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 33/36] usb: convert usb-ccid to hotplug handler API Igor Mammedov
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 34/36] usb: convert usb devices " Igor Mammedov
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 35/36] qdev: drop legacy hotplug fields/methods Igor Mammedov
2014-09-26 9:28 ` [Qemu-devel] [PATCH v2 36/36] qdev: HotplugHandler: add support for unplugging BUS-less devices Igor Mammedov
2014-10-01 8:57 ` Bharata B Rao
2014-10-01 9:57 ` Igor Mammedov
2014-10-01 10:52 ` Bharata B Rao
2014-10-01 12:43 ` Igor Mammedov
2014-10-01 12:46 ` Andreas Färber
2014-10-01 13:10 ` Igor Mammedov
2014-09-26 10:46 ` [Qemu-devel] [PATCH v2 00/36] complete conversion to hotplug-handler API Cornelia Huck
2014-09-26 11:31 ` Paolo Bonzini
2014-09-29 9:20 ` Gerd Hoffmann
2014-09-29 10:16 ` Michael S. Tsirkin
2014-09-29 10:28 ` Igor Mammedov
2014-09-29 10:42 ` Michael S. Tsirkin
2014-10-02 10:08 ` [Qemu-devel] [PATCH v2 37/36] qdev: device_del: search for to be unplugged device in 'peripheral' container Igor Mammedov
2014-10-07 11:59 ` Zhu Guihua
2014-10-07 12:10 ` Igor Mammedov
2014-10-07 13:23 ` Andreas Färber
2014-10-07 13:53 ` Igor Mammedov
2014-10-08 3:49 ` Zhu Guihua
2014-10-08 8:01 ` Paolo Bonzini
2014-10-09 1:50 ` Zhu Guihua
2014-10-09 6:21 ` Markus Armbruster
2014-10-13 17:33 ` [Qemu-devel] [PATCH v2 00/36] complete conversion to hotplug-handler API Andreas Färber
2014-10-14 9:37 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140926133121.7c5c3580@nial.usersys.redhat.com \
--to=imammedo@redhat.com \
--cc=agraf@suse.de \
--cc=amit.shah@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=dmitry@daynix.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).