From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXTkV-0001gB-9t for qemu-devel@nongnu.org; Fri, 26 Sep 2014 07:31:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXTkN-0005nU-Kn for qemu-devel@nongnu.org; Fri, 26 Sep 2014 07:31:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20485) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXTkN-0005nB-EP for qemu-devel@nongnu.org; Fri, 26 Sep 2014 07:31:35 -0400 Date: Fri, 26 Sep 2014 13:31:21 +0200 From: Igor Mammedov Message-ID: <20140926133121.7c5c3580@nial.usersys.redhat.com> In-Reply-To: <20140926131516.1535220d.cornelia.huck@de.ibm.com> References: <1411723721-20484-1-git-send-email-imammedo@redhat.com> <1411723721-20484-25-git-send-email-imammedo@redhat.com> <20140926131516.1535220d.cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 24/36] s390x: convert s390-virtio to hotplug handler API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: mst@redhat.com, amit.shah@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, borntraeger@de.ibm.com, kraxel@redhat.com, dmitry@daynix.com, pbonzini@redhat.com, rth@twiddle.net On Fri, 26 Sep 2014 13:15:16 +0200 Cornelia Huck wrote: > On Fri, 26 Sep 2014 09:28:29 +0000 > Igor Mammedov wrote: > > > Signed-off-by: Igor Mammedov > > --- > > v2: > > fix not working unplug > > While the current code for s390-virtio implements unplug, the transport > per se does not really support unplug (and never has), only hotplugging > of devices. I removed the ->unplug callback and qemu now behaves like > I'd expect: I can add devices with device_add, but device_del leaves > them in place. That would be the way to go for me. Would a path to remove unplug on top of this one do or you'd prefer me to respin this patch without unplug? > > > --- > > hw/s390x/s390-virtio-bus.c | 12 +++++++----- > > 1 file changed, 7 insertions(+), 5 deletions(-) >