From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXTpm-0005WA-MH for qemu-devel@nongnu.org; Fri, 26 Sep 2014 07:37:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXTpd-00072Y-L5 for qemu-devel@nongnu.org; Fri, 26 Sep 2014 07:37:10 -0400 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:56831) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXTpd-000712-Bq for qemu-devel@nongnu.org; Fri, 26 Sep 2014 07:37:01 -0400 Received: from /spool/local by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 26 Sep 2014 12:36:55 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 4EE012190046 for ; Fri, 26 Sep 2014 12:36:31 +0100 (BST) Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s8QBaq0F40698088 for ; Fri, 26 Sep 2014 11:36:52 GMT Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s8QBapO9021598 for ; Fri, 26 Sep 2014 05:36:52 -0600 Date: Fri, 26 Sep 2014 13:36:50 +0200 From: Cornelia Huck Message-ID: <20140926133650.6d701a7d.cornelia.huck@de.ibm.com> In-Reply-To: <20140926133121.7c5c3580@nial.usersys.redhat.com> References: <1411723721-20484-1-git-send-email-imammedo@redhat.com> <1411723721-20484-25-git-send-email-imammedo@redhat.com> <20140926131516.1535220d.cornelia.huck@de.ibm.com> <20140926133121.7c5c3580@nial.usersys.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 24/36] s390x: convert s390-virtio to hotplug handler API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: mst@redhat.com, amit.shah@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, borntraeger@de.ibm.com, kraxel@redhat.com, dmitry@daynix.com, pbonzini@redhat.com, rth@twiddle.net On Fri, 26 Sep 2014 13:31:21 +0200 Igor Mammedov wrote: > On Fri, 26 Sep 2014 13:15:16 +0200 > Cornelia Huck wrote: > > > On Fri, 26 Sep 2014 09:28:29 +0000 > > Igor Mammedov wrote: > > > > > Signed-off-by: Igor Mammedov > > > --- > > > v2: > > > fix not working unplug > > > > While the current code for s390-virtio implements unplug, the transport > > per se does not really support unplug (and never has), only hotplugging > > of devices. I removed the ->unplug callback and qemu now behaves like > > I'd expect: I can add devices with device_add, but device_del leaves > > them in place. That would be the way to go for me. > Would a path to remove unplug on top of this one do or you'd prefer > me to respin this patch without unplug? Whatever works best for you. I don't think it's worth adding an extra patch except if it saves you a respin of the whole series.