From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37839) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXURV-0001Ri-D0 for qemu-devel@nongnu.org; Fri, 26 Sep 2014 08:16:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXURL-0001bG-VM for qemu-devel@nongnu.org; Fri, 26 Sep 2014 08:16:09 -0400 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:34588) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXURL-0001aC-Ky for qemu-devel@nongnu.org; Fri, 26 Sep 2014 08:15:59 -0400 Received: from /spool/local by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 26 Sep 2014 13:15:53 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id F32942190041 for ; Fri, 26 Sep 2014 13:15:28 +0100 (BST) Received: from d06av10.portsmouth.uk.ibm.com (d06av10.portsmouth.uk.ibm.com [9.149.37.251]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s8QCFoL023199854 for ; Fri, 26 Sep 2014 12:15:50 GMT Received: from d06av10.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av10.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s8QCFnoS013023 for ; Fri, 26 Sep 2014 06:15:49 -0600 Date: Fri, 26 Sep 2014 14:15:48 +0200 From: Cornelia Huck Message-ID: <20140926141548.502ce035.cornelia.huck@de.ibm.com> In-Reply-To: <1411733296-19250-1-git-send-email-imammedo@redhat.com> References: <1411723721-20484-25-git-send-email-imammedo@redhat.com> <1411733296-19250-1-git-send-email-imammedo@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 24/36] s390x: convert s390-virtio to hotplug handler API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org On Fri, 26 Sep 2014 12:08:16 +0000 Igor Mammedov wrote: > beside of conversion, patch drops present unplug > handling, effectively disabling hot-unplug of > s390-virtio devices. > > Signed-off-by: Igor Mammedov > --- > v3: > disable unplug, Cornelia Huck > v2: > fix not working unplug > --- > hw/s390x/s390-virtio-bus.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/hw/s390x/s390-virtio-bus.c b/hw/s390x/s390-virtio-bus.c > index 6b6fb61..7fa47d4 100644 > --- a/hw/s390x/s390-virtio-bus.c > +++ b/hw/s390x/s390-virtio-bus.c > @@ -674,6 +673,7 @@ static int s390_virtio_bridge_init(SysBusDevice *dev) > static void s390_virtio_bridge_class_init(ObjectClass *klass, void *data) > { > SysBusDeviceClass *k = SYS_BUS_DEVICE_CLASS(klass); > + HotplugHandlerClass *hc = HOTPLUG_HANDLER_CLASS(klass); This line is not needed (and gives an error for me). > > k->init = s390_virtio_bridge_init; > }